Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1723693005: Remove _FDEPLUS define. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove _FDEPLUS define. We never define _FDEPLUS so all the #ifndef checks can be removed as they will always be true. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2b4267c181438671a4fb820a5ef21c65771e60cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M xfa/src/fdp/src/fde/fde_gedevice.h View 2 chunks +0 lines, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_gedevice.cpp View 5 chunks +14 lines, -20 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_geobject.h View 2 chunks +1 line, -2 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_geobject.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-23 16:01:05 UTC) #2
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-23 17:16:02 UTC) #3
dsinclair
4 years, 10 months ago (2016-02-23 17:41:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b4267c181438671a4fb820a5ef21c65771e60cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698