Better encapsulation and vector calling convention.

Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723683002

Committed: https://skia.googlesource.com/skia/+/a856e25ba1e54de6c5b6641e4c8b5c0d6b5ea42b

[herb_g, 2016-02-22 21:12:17]

Description was changed from

==========
Better encapsulation and vector calling convention.

BUG=skia:
==========

to

==========
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-02-22 21:15:14]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 21:15:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723683002/1

[commit-bot: I haz the power, 2016-02-22 21:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 21:18:07]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[herb_g, 2016-02-22 21:35:51]

Fix vector call and remove Sk4fArg.

[herb_g, 2016-02-22 21:36:23]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 21:36:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723683002/20001

[herb_g, 2016-02-22 21:38:09]

Description was changed from

==========
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-02-22 21:38:09]

herb@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[commit-bot: I haz the power, 2016-02-22 21:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 21:39:09]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-02-22 21:51:01]

Fix pointSpan to be a normal call.

[mtklein, 2016-02-22 21:52:22]

lgtm

https://codereview.chromium.org/1723683002/diff/20001/src/core/SkLinearBitmap...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1723683002/diff/20001/src/core/SkLinearBitmap...
src/core/SkLinearBitmapPipeline.cpp:20: #elif defined(SK_CPU_ARM32) &&
defined(SK_ARM_HAS_NEON)
Extra space on these.

[herb_g, 2016-02-22 22:01:50]

Make inlines VECTORCALL.

[herb_g, 2016-02-22 22:02:08]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 22:02:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723683002/60001

[commit-bot: I haz the power, 2016-02-22 22:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 22:32:50]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-02-22 22:47:27]

The CQ bit was checked by herb@google.com

[herb_g, 2016-02-22 22:47:27]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1723683002/#ps60001
(title: "Make inlines VECTORCALL.")

[commit-bot: I haz the power, 2016-02-22 22:47:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723683002/60001

[f(malita), 2016-02-22 22:48:07]

fmalita@chromium.org changed reviewers:
+ fmalita@chromium.org

[f(malita), 2016-02-22 22:48:08]

https://codereview.chromium.org/1723683002/diff/60001/src/core/SkLinearBitmap...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1723683002/diff/60001/src/core/SkLinearBitmap...
src/core/SkLinearBitmapPipeline.cpp:137: Sk4f newYs = ys;
Are the locals still needed?

[commit-bot: I haz the power, 2016-02-22 22:48:25]

Description was changed from

==========
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Better encapsulation and vector calling convention.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/a856e25ba1e54de6c5b6641e4c8b5c0d6b5ea42b
==========

[commit-bot: I haz the power, 2016-02-22 22:48:26]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a856e25ba1e54de6c5b6641e4c8b5c0d6b5ea42b

[mtklein, 2016-02-22 23:00:55]

https://codereview.chromium.org/1723683002/diff/60001/src/core/SkLinearBitmap...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1723683002/diff/60001/src/core/SkLinearBitmap...
src/core/SkLinearBitmapPipeline.cpp:137: Sk4f newYs = ys;
On 2016/02/22 22:48:08, f(malita) wrote:
> Are the locals still needed?

Nope.