Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1723673002: Reland "Mojo C++ bindings: support sync methods - part 2" (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Mojo C++ bindings: support sync methods - part 2" This CL introduces the correct re-entrancy behavior: when a sync call is waiting for response, allow incoming sync requests on the same thread to re-enter, async messages are queued until the sync call completes. The following will be in future CLs: - Support sync calls with associated interfaces. The original CL is at https://codereview.chromium.org/1713203002/ BUG=577699 Committed: https://crrev.com/8ef9022a0d352066587791b3e225ca264c688ade Cr-Commit-Position: refs/heads/master@{#376892}

Patch Set 1 : original CL #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -98 lines) Patch
M mojo/mojo_public.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.h View 1 2 3 chunks +36 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 1 2 8 chunks +100 lines, -22 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_state.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/router.h View 4 chunks +31 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 1 7 chunks +99 lines, -34 lines 0 comments Download
A mojo/public/cpp/bindings/lib/sync_handle_watcher.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/lib/sync_handle_watcher.cc View 1 1 chunk +125 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/message.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 7 chunks +14 lines, -12 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 3 chunks +228 lines, -13 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_sync_methods.mojom View 1 chunk +13 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/module.py View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, John. Would you please take a look? (The first patchset is the original CL, ...
4 years, 10 months ago (2016-02-22 23:52:07 UTC) #2
jam
lgtm
4 years, 10 months ago (2016-02-23 00:20:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723673002/40001
4 years, 10 months ago (2016-02-23 00:28:35 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 01:22:18 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 01:23:12 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ef9022a0d352066587791b3e225ca264c688ade
Cr-Commit-Position: refs/heads/master@{#376892}

Powered by Google App Engine
This is Rietveld 408576698