Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1723643002: Refactor ProfileInfoCache in c/b/ui/webui (Closed)

Created:
4 years, 10 months ago by lwchkg
Modified:
4 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, anthonyvd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ProfileInfoCache in c/b/ui/webui ProfileInfoCache is being refactored into ProfileAttributesStorage and ProfileAttributesEntry, which use profile paths instead of numerical indices in the interface. See https://codereview.chromium.org/1599013002/ for details. BUG=305720 Committed: https://crrev.com/669281a019ab42f1f854869d1580df0b2c071c70 Cr-Commit-Position: refs/heads/master@{#376980}

Patch Set 1 #

Patch Set 2 : Fixed a signed/unsigned integer conversion, one removed #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -54 lines) Patch
M chrome/browser/ui/webui/app_launcher_login_handler.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/profile_info_watcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/profile_info_watcher.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/people_handler.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc View 1 5 chunks +22 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lwchkg
Dear Dan, PTAL and thanks! Regards, WC Leung.
4 years, 10 months ago (2016-02-22 18:24:34 UTC) #2
Dan Beam
lgtm
4 years, 10 months ago (2016-02-23 02:34:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723643002/20001
4 years, 10 months ago (2016-02-23 13:32:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-23 14:15:48 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 14:17:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/669281a019ab42f1f854869d1580df0b2c071c70
Cr-Commit-Position: refs/heads/master@{#376980}

Powered by Google App Engine
This is Rietveld 408576698