sdk/lib/io/http_impl.dart - Issue 172363002: Fix Windows event-handler, where write can 'complete' with 0 bytes written.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/http_impl.dart

Issue 172363002: Fix Windows event-handler, where write can 'complete' with 0 bytes written. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/http_impl.dart

diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart

index 2f852dce0b03de416ba3afb2524521945a7d0353..249bd2e65381c611161c84a3cc636cf68b29601a 100644

--- a/sdk/lib/io/http_impl.dart

+++ b/sdk/lib/io/http_impl.dart

@@ -1343,8 +1343,9 @@ class _HttpClientConnection {

_nextResponseCompleter.future

.then((incoming) {

_currentUri = null;

- incoming.dataDone.then((_) {

- if (!_dispose &&

+ incoming.dataDone.then((closing) {

+ if (!closing &&

+ !_dispose &&

incoming.headers.persistentConnection &&

request.persistentConnection) {

// Return connection, now we are done.

« no previous file with comments | « runtime/bin/eventhandler_win.cc ('k') | no next file » | no next file with comments »