GN: fix a DCHECK() when generating Visual Studio solution files

GN: fix a DCHECK() when generating Visual Studio solution files

VisualStudioWriter::WriteSolutionFileContents() used RebasePath()
with |source_root| = "/" which is forbidden. It always uses system
absolute paths, thus we can use |source_root| = "".

R=brettw@chromium.org
BUG=

Committed: https://crrev.com/bbe9c04f0889293cea85b6806145e26e1670a223
Cr-Commit-Position: refs/heads/master@{#377258}

[brettw, 2016-02-23 19:07:41]

LGTM with parameters just removed.

https://codereview.chromium.org/1723613003/diff/1/tools/gn/visual_studio_writ...
File tools/gn/visual_studio_writer.cc (right):

https://codereview.chromium.org/1723613003/diff/1/tools/gn/visual_studio_writ...
tools/gn/visual_studio_writer.cc:609: << ")\", \"" << RebasePath(folder->path,
solution_dir, "") << "\", \""
Actually, you should just delete the third parameter. It defaults to
StringPiece() which will be cleaner and trivially faster than constructing a
string piece from a constant empty string.

[NGG, 2016-02-24 09:43:46]

https://codereview.chromium.org/1723613003/diff/1/tools/gn/visual_studio_writ...
File tools/gn/visual_studio_writer.cc (right):

https://codereview.chromium.org/1723613003/diff/1/tools/gn/visual_studio_writ...
tools/gn/visual_studio_writer.cc:609: << ")\", \"" << RebasePath(folder->path,
solution_dir, "") << "\", \""
On 2016/02/23 19:07:40, brettw wrote:
> Actually, you should just delete the third parameter. It defaults to
> StringPiece() which will be cleaner and trivially faster than constructing a
> string piece from a constant empty string.

Done.

[NGG, 2016-02-24 09:44:09]

The CQ bit was checked by ngg@ngg.hu

[NGG, 2016-02-24 09:44:09]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1723613003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-24 09:44:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723613003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723613003/20001

[commit-bot: I haz the power, 2016-02-24 10:18:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 10:20:45]

Description was changed from

==========
GN: fix a DCHECK() when generating Visual Studio solution files

VisualStudioWriter::WriteSolutionFileContents() used RebasePath()
with |source_root| = "/" which is forbidden. It always uses system
absolute paths, thus we can use |source_root| = "".

R=brettw@chromium.org
BUG=
==========

to

==========
GN: fix a DCHECK() when generating Visual Studio solution files

VisualStudioWriter::WriteSolutionFileContents() used RebasePath()
with |source_root| = "/" which is forbidden. It always uses system
absolute paths, thus we can use |source_root| = "".

R=brettw@chromium.org
BUG=

Committed: https://crrev.com/bbe9c04f0889293cea85b6806145e26e1670a223
Cr-Commit-Position: refs/heads/master@{#377258}
==========

[commit-bot: I haz the power, 2016-02-24 10:20:45]

Patchset 2 (id:??) landed as
https://crrev.com/bbe9c04f0889293cea85b6806145e26e1670a223
Cr-Commit-Position: refs/heads/master@{#377258}