chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_libsecret.cc ('K') | « chrome/browser/ui/views/passwords/manage_password_items_view.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.cc » ('j') | components/autofill/core/common/password_form.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

index 7209458707670660d2b9742f672b7f4c65888ee7..03d3657d19506595ba8e862e3b9756c75a829230 100644

--- a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

@@ -179,7 +179,7 @@ IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,

GURL icon_url("https://google.com/icon.png");

form.icon_url = icon_url;

form.display_name = base::ASCIIToUTF16("Peter Pen");

- form.federation_url = GURL("https://google.com/federation");

+ form.federation_origin = url::Origin(GURL("https://google.com/federation"));

local_credentials.push_back(new autofill::PasswordForm(form));

// Prepare to capture the network request.

@@ -219,7 +219,7 @@ IN_PROC_BROWSER_TEST_F(