chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/native_backend_libsecret.cc ('K') | « chrome/browser/ui/cocoa/passwords/passwords_list_view_controller_unittest.mm ('k') | chrome/browser/ui/passwords/manage_passwords_state.cc » ('j') | components/autofill/core/common/password_form.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index 9322681dbf520dfa4db85353aa7cbe41d4bff462..61606f4355dd806f8384061535a6abb9f643c546 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -356,10 +356,10 @@ void ManagePasswordsBubbleModel::UpdatePendingStateTitle() {

title_brand_link_range_ = gfx::Range();

PasswordTittleType type =

state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE

- ? PasswordTittleType::UPDATE_PASSWORD

- : (pending_password_.federation_url.is_empty()

- ? PasswordTittleType::SAVE_PASSWORD

- : PasswordTittleType::SAVE_ACCOUNT);

+ ? PasswordTittleType::UPDATE_PASSWORD

+ : (pending_password_.federation_origin.unique()

+ ? PasswordTittleType::SAVE_PASSWORD

+ : PasswordTittleType::SAVE_ACCOUNT);

GetSavePasswordDialogTitleTextAndLinkRange(

web_contents()->GetVisibleURL(), origin(),

GetSmartLockBrandingState(GetProfile()) !=