Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 old_form_google_.date_created = base::Time::Now(); 177 old_form_google_.date_created = base::Time::Now();
178 178
179 form_google_ = old_form_google_; 179 form_google_ = old_form_google_;
180 form_google_.times_used = 3; 180 form_google_.times_used = 3;
181 form_google_.type = PasswordForm::TYPE_GENERATED; 181 form_google_.type = PasswordForm::TYPE_GENERATED;
182 form_google_.form_data.name = UTF8ToUTF16("form_name"); 182 form_google_.form_data.name = UTF8ToUTF16("form_name");
183 form_google_.date_synced = base::Time::Now(); 183 form_google_.date_synced = base::Time::Now();
184 form_google_.date_created = old_form_google_.date_created; 184 form_google_.date_created = old_form_google_.date_created;
185 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 185 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
186 form_google_.icon_url = GURL("http://www.google.com/icon"); 186 form_google_.icon_url = GURL("http://www.google.com/icon");
187 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 187 form_google_.federation_origin =
188 url::Origin(GURL("http://www.google.com/"));
188 form_google_.skip_zero_click = true; 189 form_google_.skip_zero_click = true;
189 form_google_.generation_upload_status = PasswordForm::NEGATIVE_SIGNAL_SENT; 190 form_google_.generation_upload_status = PasswordForm::NEGATIVE_SIGNAL_SENT;
190 191
191 form_isc_.origin = GURL("http://www.isc.org/"); 192 form_isc_.origin = GURL("http://www.isc.org/");
192 form_isc_.action = GURL("http://www.isc.org/auth"); 193 form_isc_.action = GURL("http://www.isc.org/auth");
193 form_isc_.username_element = UTF8ToUTF16("id"); 194 form_isc_.username_element = UTF8ToUTF16("id");
194 form_isc_.username_value = UTF8ToUTF16("janedoe"); 195 form_isc_.username_value = UTF8ToUTF16("janedoe");
195 form_isc_.password_element = UTF8ToUTF16("passwd"); 196 form_isc_.password_element = UTF8ToUTF16("passwd");
196 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 197 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
197 form_isc_.submit_element = UTF8ToUTF16("login"); 198 form_isc_.submit_element = UTF8ToUTF16("login");
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 if (check_date_created) { 234 if (check_date_created) {
234 EXPECT_EQ(expected.date_created, actual.date_created); 235 EXPECT_EQ(expected.date_created, actual.date_created);
235 } 236 }
236 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 237 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
237 EXPECT_EQ(expected.type, actual.type); 238 EXPECT_EQ(expected.type, actual.type);
238 EXPECT_EQ(expected.times_used, actual.times_used); 239 EXPECT_EQ(expected.times_used, actual.times_used);
239 EXPECT_EQ(expected.scheme, actual.scheme); 240 EXPECT_EQ(expected.scheme, actual.scheme);
240 EXPECT_EQ(expected.date_synced, actual.date_synced); 241 EXPECT_EQ(expected.date_synced, actual.date_synced);
241 EXPECT_EQ(expected.display_name, actual.display_name); 242 EXPECT_EQ(expected.display_name, actual.display_name);
242 EXPECT_EQ(expected.icon_url, actual.icon_url); 243 EXPECT_EQ(expected.icon_url, actual.icon_url);
243 EXPECT_EQ(expected.federation_url, actual.federation_url); 244 EXPECT_EQ(expected.federation_origin.Serialize(),
245 actual.federation_origin.Serialize());
244 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click); 246 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
245 EXPECT_EQ(expected.generation_upload_status, actual.generation_upload_status); 247 EXPECT_EQ(expected.generation_upload_status, actual.generation_upload_status);
246 } 248 }
247 249
248 // static 250 // static
249 void NativeBackendKWalletTestBase::CheckPasswordChanges( 251 void NativeBackendKWalletTestBase::CheckPasswordChanges(
250 const PasswordStoreChangeList& expected, 252 const PasswordStoreChangeList& expected,
251 const PasswordStoreChangeList& actual) { 253 const PasswordStoreChangeList& actual) {
252 ASSERT_EQ(expected.size(), actual.size()); 254 ASSERT_EQ(expected.size(), actual.size());
253 for (size_t i = 0; i < expected.size(); ++i) { 255 for (size_t i = 0; i < expected.size(); ++i) {
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 pickle->WriteInt(form.type); 1141 pickle->WriteInt(form.type);
1140 pickle->WriteInt(form.times_used); 1142 pickle->WriteInt(form.times_used);
1141 autofill::SerializeFormData(form.form_data, pickle); 1143 autofill::SerializeFormData(form.form_data, pickle);
1142 if (effective_version < 3) 1144 if (effective_version < 3)
1143 return; 1145 return;
1144 pickle->WriteInt64(form.date_synced.ToInternalValue()); 1146 pickle->WriteInt64(form.date_synced.ToInternalValue());
1145 if (effective_version < 4) 1147 if (effective_version < 4)
1146 return; 1148 return;
1147 pickle->WriteString16(form.display_name); 1149 pickle->WriteString16(form.display_name);
1148 pickle->WriteString(form.icon_url.spec()); 1150 pickle->WriteString(form.icon_url.spec());
1149 pickle->WriteString(form.federation_url.spec()); 1151 pickle->WriteString(form.federation_origin.Serialize());
1150 pickle->WriteBool(form.skip_zero_click); 1152 pickle->WriteBool(form.skip_zero_click);
1151 if (effective_version < 7) 1153 if (effective_version < 7)
1152 return; 1154 return;
1153 pickle->WriteInt(form.generation_upload_status); 1155 pickle->WriteInt(form.generation_upload_status);
1154 } 1156 }
1155 1157
1156 void NativeBackendKWalletPickleTest::CreateVersion0Pickle( 1158 void NativeBackendKWalletPickleTest::CreateVersion0Pickle(
1157 bool size_32, 1159 bool size_32,
1158 const PasswordForm& form, 1160 const PasswordForm& form,
1159 base::Pickle* pickle) { 1161 base::Pickle* pickle) {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
1220 CheckPasswordForm(form, *form_list[0], true); 1222 CheckPasswordForm(form, *form_list[0], true);
1221 } 1223 }
1222 1224
1223 void NativeBackendKWalletPickleTest::CheckVersion3Pickle() { 1225 void NativeBackendKWalletPickleTest::CheckVersion3Pickle() {
1224 base::Pickle pickle; 1226 base::Pickle pickle;
1225 PasswordForm default_values; 1227 PasswordForm default_values;
1226 PasswordForm form = form_google_; 1228 PasswordForm form = form_google_;
1227 // Remove the fields which were not present in version #3. 1229 // Remove the fields which were not present in version #3.
1228 form.display_name = default_values.display_name; 1230 form.display_name = default_values.display_name;
1229 form.icon_url = default_values.icon_url; 1231 form.icon_url = default_values.icon_url;
1230 form.federation_url = default_values.federation_url; 1232 form.federation_origin = default_values.federation_origin;
1231 form.skip_zero_click = default_values.skip_zero_click; 1233 form.skip_zero_click = default_values.skip_zero_click;
1232 form.generation_upload_status = default_values.generation_upload_status; 1234 form.generation_upload_status = default_values.generation_upload_status;
1233 CreateVersion1PlusPickle(form, &pickle, 3, 3); 1235 CreateVersion1PlusPickle(form, &pickle, 3, 3);
1234 1236
1235 ScopedVector<PasswordForm> form_list = 1237 ScopedVector<PasswordForm> form_list =
1236 NativeBackendKWalletStub::DeserializeValue(form.signon_realm, pickle); 1238 NativeBackendKWalletStub::DeserializeValue(form.signon_realm, pickle);
1237 1239
1238 EXPECT_EQ(1u, form_list.size()); 1240 EXPECT_EQ(1u, form_list.size());
1239 if (form_list.size() > 0) 1241 if (form_list.size() > 0)
1240 CheckPasswordForm(form, *form_list[0], false); 1242 CheckPasswordForm(form, *form_list[0], false);
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 } 1324 }
1323 1325
1324 TEST_F(NativeBackendKWalletPickleTest, CheckVersion5Pickle) { 1326 TEST_F(NativeBackendKWalletPickleTest, CheckVersion5Pickle) {
1325 CheckVersion5Pickle(); 1327 CheckVersion5Pickle();
1326 } 1328 }
1327 1329
1328 TEST_F(NativeBackendKWalletPickleTest, CheckVersion6Pickle) { 1330 TEST_F(NativeBackendKWalletPickleTest, CheckVersion6Pickle) {
1329 CheckVersion6Pickle(false); 1331 CheckVersion6Pickle(false);
1330 CheckVersion6Pickle(true); 1332 CheckVersion6Pickle(true);
1331 } 1333 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698