Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 1723583004: CREDENTIAL: Convert federations from URLs to origins throughout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdarg.h> 5 #include <stdarg.h>
6 #include <stddef.h> 6 #include <stddef.h>
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <map> 9 #include <map>
10 #include <utility> 10 #include <utility>
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 EXPECT_EQ(expected.ssl_valid, actual.ssl_valid); 310 EXPECT_EQ(expected.ssl_valid, actual.ssl_valid);
311 EXPECT_EQ(expected.preferred, actual.preferred); 311 EXPECT_EQ(expected.preferred, actual.preferred);
312 EXPECT_EQ(expected.date_created, actual.date_created); 312 EXPECT_EQ(expected.date_created, actual.date_created);
313 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user); 313 EXPECT_EQ(expected.blacklisted_by_user, actual.blacklisted_by_user);
314 EXPECT_EQ(expected.type, actual.type); 314 EXPECT_EQ(expected.type, actual.type);
315 EXPECT_EQ(expected.times_used, actual.times_used); 315 EXPECT_EQ(expected.times_used, actual.times_used);
316 EXPECT_EQ(expected.scheme, actual.scheme); 316 EXPECT_EQ(expected.scheme, actual.scheme);
317 EXPECT_EQ(expected.date_synced, actual.date_synced); 317 EXPECT_EQ(expected.date_synced, actual.date_synced);
318 EXPECT_EQ(expected.display_name, actual.display_name); 318 EXPECT_EQ(expected.display_name, actual.display_name);
319 EXPECT_EQ(expected.icon_url, actual.icon_url); 319 EXPECT_EQ(expected.icon_url, actual.icon_url);
320 EXPECT_EQ(expected.federation_url, actual.federation_url); 320 EXPECT_EQ(expected.federation_origin.Serialize(),
321 actual.federation_origin.Serialize());
321 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click); 322 EXPECT_EQ(expected.skip_zero_click, actual.skip_zero_click);
322 EXPECT_EQ(expected.generation_upload_status, 323 EXPECT_EQ(expected.generation_upload_status,
323 actual.generation_upload_status); 324 actual.generation_upload_status);
324 } 325 }
325 } 326 }
326 327
327 void CheckPasswordChangesWithResult(const PasswordStoreChangeList* expected, 328 void CheckPasswordChangesWithResult(const PasswordStoreChangeList* expected,
328 const PasswordStoreChangeList* actual, 329 const PasswordStoreChangeList* actual,
329 bool result) { 330 bool result) {
330 EXPECT_TRUE(result); 331 EXPECT_TRUE(result);
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 form_google_.username_value = UTF8ToUTF16("joeschmoe"); 365 form_google_.username_value = UTF8ToUTF16("joeschmoe");
365 form_google_.password_element = UTF8ToUTF16("pass"); 366 form_google_.password_element = UTF8ToUTF16("pass");
366 form_google_.password_value = UTF8ToUTF16("seekrit"); 367 form_google_.password_value = UTF8ToUTF16("seekrit");
367 form_google_.submit_element = UTF8ToUTF16("submit"); 368 form_google_.submit_element = UTF8ToUTF16("submit");
368 form_google_.signon_realm = "http://www.google.com/"; 369 form_google_.signon_realm = "http://www.google.com/";
369 form_google_.type = PasswordForm::TYPE_GENERATED; 370 form_google_.type = PasswordForm::TYPE_GENERATED;
370 form_google_.date_created = base::Time::Now(); 371 form_google_.date_created = base::Time::Now();
371 form_google_.date_synced = base::Time::Now(); 372 form_google_.date_synced = base::Time::Now();
372 form_google_.display_name = UTF8ToUTF16("Joe Schmoe"); 373 form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
373 form_google_.icon_url = GURL("http://www.google.com/icon"); 374 form_google_.icon_url = GURL("http://www.google.com/icon");
374 form_google_.federation_url = GURL("http://www.google.com/federation_url"); 375 form_google_.federation_origin =
376 url::Origin(GURL("http://www.google.com/"));
375 form_google_.skip_zero_click = true; 377 form_google_.skip_zero_click = true;
376 form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT; 378 form_google_.generation_upload_status = PasswordForm::POSITIVE_SIGNAL_SENT;
377 form_google_.form_data.name = UTF8ToUTF16("form_name"); 379 form_google_.form_data.name = UTF8ToUTF16("form_name");
378 380
379 form_facebook_.origin = GURL("http://www.facebook.com/"); 381 form_facebook_.origin = GURL("http://www.facebook.com/");
380 form_facebook_.action = GURL("http://www.facebook.com/login"); 382 form_facebook_.action = GURL("http://www.facebook.com/login");
381 form_facebook_.username_element = UTF8ToUTF16("user"); 383 form_facebook_.username_element = UTF8ToUTF16("user");
382 form_facebook_.username_value = UTF8ToUTF16("a"); 384 form_facebook_.username_value = UTF8ToUTF16("a");
383 form_facebook_.password_element = UTF8ToUTF16("password"); 385 form_facebook_.password_element = UTF8ToUTF16("password");
384 form_facebook_.password_value = UTF8ToUTF16("b"); 386 form_facebook_.password_value = UTF8ToUTF16("b");
385 form_facebook_.submit_element = UTF8ToUTF16("submit"); 387 form_facebook_.submit_element = UTF8ToUTF16("submit");
386 form_facebook_.signon_realm = "http://www.facebook.com/"; 388 form_facebook_.signon_realm = "http://www.facebook.com/";
387 form_facebook_.date_created = base::Time::Now(); 389 form_facebook_.date_created = base::Time::Now();
388 form_facebook_.date_synced = base::Time::Now(); 390 form_facebook_.date_synced = base::Time::Now();
389 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe"); 391 form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");
390 form_facebook_.icon_url = GURL("http://www.facebook.com/icon"); 392 form_facebook_.icon_url = GURL("http://www.facebook.com/icon");
391 form_facebook_.federation_url = GURL("http://www.facebook.com/federation"); 393 form_facebook_.federation_origin =
394 url::Origin(GURL("http://www.facebook.com/"));
392 form_facebook_.skip_zero_click = true; 395 form_facebook_.skip_zero_click = true;
393 form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT; 396 form_facebook_.generation_upload_status = PasswordForm::NO_SIGNAL_SENT;
394 397
395 form_isc_.origin = GURL("http://www.isc.org/"); 398 form_isc_.origin = GURL("http://www.isc.org/");
396 form_isc_.action = GURL("http://www.isc.org/auth"); 399 form_isc_.action = GURL("http://www.isc.org/auth");
397 form_isc_.username_element = UTF8ToUTF16("id"); 400 form_isc_.username_element = UTF8ToUTF16("id");
398 form_isc_.username_value = UTF8ToUTF16("janedoe"); 401 form_isc_.username_value = UTF8ToUTF16("janedoe");
399 form_isc_.password_element = UTF8ToUTF16("passwd"); 402 form_isc_.password_element = UTF8ToUTF16("passwd");
400 form_isc_.password_value = UTF8ToUTF16("ihazabukkit"); 403 form_isc_.password_value = UTF8ToUTF16("ihazabukkit");
401 form_isc_.submit_element = UTF8ToUTF16("login"); 404 form_isc_.submit_element = UTF8ToUTF16("login");
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
481 CheckUint32Attribute(item, "preferred", form.preferred); 484 CheckUint32Attribute(item, "preferred", form.preferred);
482 // We don't check the date created. It varies. 485 // We don't check the date created. It varies.
483 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user); 486 CheckUint32Attribute(item, "blacklisted_by_user", form.blacklisted_by_user);
484 CheckUint32Attribute(item, "type", form.type); 487 CheckUint32Attribute(item, "type", form.type);
485 CheckUint32Attribute(item, "times_used", form.times_used); 488 CheckUint32Attribute(item, "times_used", form.times_used);
486 CheckUint32Attribute(item, "scheme", form.scheme); 489 CheckUint32Attribute(item, "scheme", form.scheme);
487 CheckStringAttribute(item, "date_synced", base::Int64ToString( 490 CheckStringAttribute(item, "date_synced", base::Int64ToString(
488 form.date_synced.ToInternalValue())); 491 form.date_synced.ToInternalValue()));
489 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name)); 492 CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));
490 CheckStringAttribute(item, "avatar_url", form.icon_url.spec()); 493 CheckStringAttribute(item, "avatar_url", form.icon_url.spec());
491 CheckStringAttribute(item, "federation_url", form.federation_url.spec()); 494 CheckStringAttribute(item, "federation_url",
495 form.federation_origin.Serialize());
492 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click); 496 CheckUint32Attribute(item, "skip_zero_click", form.skip_zero_click);
493 CheckUint32Attribute(item, "generation_upload_status", 497 CheckUint32Attribute(item, "generation_upload_status",
494 form.generation_upload_status); 498 form.generation_upload_status);
495 CheckStringAttribute(item, "application", app_string); 499 CheckStringAttribute(item, "application", app_string);
496 autofill::FormData actual; 500 autofill::FormData actual;
497 DeserializeFormDataFromBase64String( 501 DeserializeFormDataFromBase64String(
498 item->attributes.at("form_data").value_string, &actual); 502 item->attributes.at("form_data").value_string, &actual);
499 EXPECT_TRUE(form.form_data.SameFormAs(actual)); 503 EXPECT_TRUE(form.form_data.SameFormAs(actual));
500 } 504 }
501 505
(...skipping 731 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 base::Bind(&CheckTrue)); 1237 base::Bind(&CheckTrue));
1234 1238
1235 RunBothThreads(); 1239 RunBothThreads();
1236 1240
1237 EXPECT_EQ(2u, form_list.size()); 1241 EXPECT_EQ(2u, form_list.size());
1238 EXPECT_THAT(form_list, UnorderedElementsAre(Pointee(form_google_), 1242 EXPECT_THAT(form_list, UnorderedElementsAre(Pointee(form_google_),
1239 Pointee(form_facebook_))); 1243 Pointee(form_facebook_)));
1240 } 1244 }
1241 1245
1242 // TODO(mdm): add more basic tests here at some point. 1246 // TODO(mdm): add more basic tests here at some point.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698