CREDENTIAL: Filter affiliated credentials.

components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/credential_manager_dispatcher.h"
 
 #include <stdint.h>
 
 #include <string>
 #include <vector>
@@ skipping 479 matching lines @@
   EXPECT_FALSE(passwords[form_.signon_realm][0].skip_zero_click);
 }
 
 TEST_F(CredentialManagerDispatcherTest,
        CredentialManagerOnRequireUserMediationWithAffiliation) {
   store_->AddLogin(form_);
   store_->AddLogin(cross_origin_form_);
   store_->AddLogin(affiliated_form1_);
   store_->AddLogin(affiliated_form2_);
 
-  MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
-  store_->SetAffiliatedMatchHelper(make_scoped_ptr(mock_helper));
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
 
   std::vector<GURL> federations;
   std::vector<std::string> affiliated_realms;
   affiliated_realms.push_back(kTestAndroidRealm1);
-  mock_helper->ExpectCallToGetAffiliatedAndroidRealms(
-      dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
   RunAllPendingTasks();
 
   TestPasswordStore::PasswordMap passwords = store_->stored_passwords();
   EXPECT_EQ(4U, passwords.size());
   EXPECT_FALSE(passwords[form_.signon_realm][0].skip_zero_click);
   EXPECT_FALSE(passwords[cross_origin_form_.signon_realm][0].skip_zero_click);
   EXPECT_FALSE(passwords[affiliated_form1_.signon_realm][0].skip_zero_click);
   EXPECT_FALSE(passwords[affiliated_form2_.signon_realm][0].skip_zero_click);
 
   dispatcher()->OnRequireUserMediation(kRequestId);
@@ skipping 149 matching lines @@
 
   std::vector<GURL> federations;
   federations.push_back(GURL("https://not-example.com/"));
 
   EXPECT_CALL(*client_, NotifyUserAutoSigninBlockedOnFirstRunPtr(_)).Times(0);
   dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
 
   ExpectZeroClickSignInFailure();
 }
 
+TEST_F(CredentialManagerDispatcherTest,
+       CredentialManagerOnRequestCredentialAffiliatedPasswordMatch) {
+  store_->AddLogin(affiliated_form1_);
+  client_->set_first_run_seen(true);
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
+
+  std::vector<GURL> federations;
+  std::vector<std::string> affiliated_realms;
+  affiliated_realms.push_back(kTestAndroidRealm1);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+
+  // We pass in 'true' for the 'include_passwords' argument to ensure that
+  // password-type credentials are included as potential matches.
+  dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
+
+  ExpectZeroClickSignInSuccess(CredentialType::CREDENTIAL_TYPE_PASSWORD);
+}
+
+TEST_F(CredentialManagerDispatcherTest,
+       CredentialManagerOnRequestCredentialAffiliatedPasswordNoMatch) {
+  store_->AddLogin(affiliated_form1_);
+  client_->set_first_run_seen(true);
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
+
+  std::vector<GURL> federations;
+  std::vector<std::string> affiliated_realms;
+  affiliated_realms.push_back(kTestAndroidRealm1);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+
+  // We pass in 'false' for the 'include_passwords' argument to ensure that
+  // password-type credentials are excluded as potential matches.
+  dispatcher()->OnRequestCredential(kRequestId, true, false, federations);
+
+  ExpectZeroClickSignInFailure();
+}
+
+TEST_F(CredentialManagerDispatcherTest,
+       CredentialManagerOnRequestCredentialAffiliatedFederatedMatch) {
+  affiliated_form1_.federation_url = GURL("https://example.com/");
+  store_->AddLogin(affiliated_form1_);
+  client_->set_first_run_seen(true);
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
+
+  std::vector<GURL> federations;
+  federations.push_back(GURL("https://example.com/"));
+
+  std::vector<std::string> affiliated_realms;
+  affiliated_realms.push_back(kTestAndroidRealm1);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+
+  dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
+
+  ExpectZeroClickSignInSuccess(CredentialType::CREDENTIAL_TYPE_FEDERATED);
+}
+
+TEST_F(CredentialManagerDispatcherTest,
+       CredentialManagerOnRequestCredentialAffiliatedFederatedNoMatch) {
+  affiliated_form1_.federation_url = GURL("https://example.com/");
+  store_->AddLogin(affiliated_form1_);
+  client_->set_first_run_seen(true);
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
+
+  std::vector<GURL> federations;
+  federations.push_back(GURL("https://not-example.com/"));
+
+  std::vector<std::string> affiliated_realms;
+  affiliated_realms.push_back(kTestAndroidRealm1);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+
+  dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
+
+  ExpectZeroClickSignInFailure();
+}
+
 TEST_F(CredentialManagerDispatcherTest, RequestCredentialWithoutFirstRun) {
   client_->set_first_run_seen(false);
 
   store_->AddLogin(form_);
 
   std::vector<GURL> federations;
   EXPECT_CALL(*client_,
               NotifyUserAutoSigninBlockedOnFirstRunPtr(testing::Pointee(form_)))
       .Times(1);
   dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
@@ skipping 238 matching lines @@
   EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, base::get<1>(param).type);
 }
 
 TEST_F(CredentialManagerDispatcherTest,
        ZeroClickWithAffiliatedFormInPasswordStore) {
   // Insert the affiliated form into the store, and mock out the association
   // with the current origin. As it's the only form matching the origin, it
   // ought to be returned automagically.
   store_->AddLogin(affiliated_form1_);
 
-  MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
-  store_->SetAffiliatedMatchHelper(make_scoped_ptr(mock_helper));
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
 
   std::vector<GURL> federations;
   std::vector<std::string> affiliated_realms;
   affiliated_realms.push_back(kTestAndroidRealm1);
-  mock_helper->ExpectCallToGetAffiliatedAndroidRealms(
-      dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
 
   dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
 
   ExpectZeroClickSignInSuccess(CredentialType::CREDENTIAL_TYPE_PASSWORD);
 }
 
 TEST_F(CredentialManagerDispatcherTest,
        ZeroClickWithTwoAffiliatedFormsInPasswordStore) {
   // Insert two affiliated forms into the store, and mock out the association
   // with the current origin. Multiple forms === no zero-click sign in.
   store_->AddLogin(affiliated_form1_);
   store_->AddLogin(affiliated_form2_);
 
-  MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
-  store_->SetAffiliatedMatchHelper(make_scoped_ptr(mock_helper));
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
 
   std::vector<GURL> federations;
   std::vector<std::string> affiliated_realms;
   affiliated_realms.push_back(kTestAndroidRealm1);
   affiliated_realms.push_back(kTestAndroidRealm2);
-  mock_helper->ExpectCallToGetAffiliatedAndroidRealms(
-      dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
 
   dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
 
   ExpectZeroClickSignInFailure();
 }
 
 TEST_F(CredentialManagerDispatcherTest,
        ZeroClickWithUnaffiliatedFormsInPasswordStore) {
   // Insert the affiliated form into the store, but don't mock out the
   // association with the current origin. No association === no zero-click sign
   // in.
   store_->AddLogin(affiliated_form1_);
 
-  MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
-  store_->SetAffiliatedMatchHelper(make_scoped_ptr(mock_helper));
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
 
   std::vector<GURL> federations;
   std::vector<std::string> affiliated_realms;
-  mock_helper->ExpectCallToGetAffiliatedAndroidRealms(
-      dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
 
   dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
 
   ExpectZeroClickSignInFailure();
 }
 
 TEST_F(CredentialManagerDispatcherTest,
        ZeroClickWithFormAndUnaffiliatedFormsInPasswordStore) {
   // Insert the affiliated form into the store, along with a real form for the
   // origin, and don't mock out the association with the current origin. No
   // association + existing form === zero-click sign in.
   store_->AddLogin(form_);
   store_->AddLogin(affiliated_form1_);
 
-  MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
-  store_->SetAffiliatedMatchHelper(make_scoped_ptr(mock_helper));
+  auto mock_helper = make_scoped_ptr(new MockAffiliatedMatchHelper);
+  store_->SetAffiliatedMatchHelper(std::move(mock_helper));
 
   std::vector<GURL> federations;
   std::vector<std::string> affiliated_realms;
-  mock_helper->ExpectCallToGetAffiliatedAndroidRealms(
-      dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
+  static_cast<MockAffiliatedMatchHelper*>(store_->affiliated_match_helper())
+      ->ExpectCallToGetAffiliatedAndroidRealms(
+          dispatcher_->GetSynthesizedFormForOrigin(), affiliated_realms);
 
   dispatcher()->OnRequestCredential(kRequestId, true, true, federations);
 
   ExpectZeroClickSignInSuccess(CredentialType::CREDENTIAL_TYPE_PASSWORD);
 }
 
 TEST_F(CredentialManagerDispatcherTest, GetSynthesizedFormForOrigin) {
   autofill::PasswordForm synthesized =
       dispatcher_->GetSynthesizedFormForOrigin();
   EXPECT_EQ(kTestWebOrigin, synthesized.origin.spec());
   EXPECT_EQ(kTestWebOrigin, synthesized.signon_realm);
   EXPECT_EQ(autofill::PasswordForm::SCHEME_HTML, synthesized.scheme);
   EXPECT_TRUE(synthesized.ssl_valid);
 }
 
 }  // namespace password_manager