Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 172353002: Fix double wallpaper animation for public pods (Closed)

Created:
6 years, 10 months ago by Nikita (slow)
Modified:
6 years, 10 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fix double wallpaper animation for public pods. Public session pods are placed first so this should be reflected in UserManager::EnsureUsersLoaded() because UserManager::GetUsers() user list is used to determine first user wallpaper. BUG=344858 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252080

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 3 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nikita (slow)
6 years, 10 months ago (2014-02-19 12:45:31 UTC) #1
bartfab (slow)
lgtm https://codereview.chromium.org/172353002/diff/1/chrome/browser/chromeos/login/user_manager_impl.cc File chrome/browser/chromeos/login/user_manager_impl.cc (right): https://codereview.chromium.org/172353002/diff/1/chrome/browser/chromeos/login/user_manager_impl.cc#newcode1173 chrome/browser/chromeos/login/user_manager_impl.cc:1173: // Load public accounts first. Nit: We call ...
6 years, 10 months ago (2014-02-19 14:24:22 UTC) #2
Nikita (slow)
https://codereview.chromium.org/172353002/diff/1/chrome/browser/chromeos/login/user_manager_impl.cc File chrome/browser/chromeos/login/user_manager_impl.cc (right): https://codereview.chromium.org/172353002/diff/1/chrome/browser/chromeos/login/user_manager_impl.cc#newcode1173 chrome/browser/chromeos/login/user_manager_impl.cc:1173: // Load public accounts first. On 2014/02/19 14:24:22, bartfab ...
6 years, 10 months ago (2014-02-19 14:34:59 UTC) #3
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 10 months ago (2014-02-19 14:35:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/172353002/50001
6 years, 10 months ago (2014-02-19 14:35:09 UTC) #5
Nikita (slow)
The CQ bit was unchecked by nkostylev@chromium.org
6 years, 10 months ago (2014-02-19 14:52:42 UTC) #6
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 10 months ago (2014-02-19 15:01:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/172353002/50001
6 years, 10 months ago (2014-02-19 15:04:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/172353002/50001
6 years, 10 months ago (2014-02-19 15:33:33 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 20:59:54 UTC) #10
Message was sent while issue was closed. 
Change committed as 252080

Powered by Google App Engine
This is Rietveld 408576698