Round to nearest in ScalarTo256.

Round to nearest in ScalarTo256.

This is a followup to https://codereview.chromium.org/1693683002 per discussion on https://codereview.chromium.org/1691403002.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723483004

Committed: https://skia.googlesource.com/skia/+/43437c2f1928073a30c2bab6d32df854658235ec

[dogben, 2016-02-22 23:32:17]

Description was changed from

==========
Round to nearest in ScalarTo256.

This is a followup to https://codereview.chromium.org/1693683002 per discussion
on https://codereview.chromium.org/1691403002.

BUG=skia:
==========

to

==========
Round to nearest in ScalarTo256.

This is a followup to https://codereview.chromium.org/1693683002 per discussion
on https://codereview.chromium.org/1691403002.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[dogben, 2016-02-22 23:32:36]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 23:32:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723483004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723483004/1

[commit-bot: I haz the power, 2016-02-22 23:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 23:50:45]

Dry run: This issue passed the CQ dry run.

[dogben, 2016-02-22 23:55:13]

benjaminwagner@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[reed1, 2016-02-23 15:35:36]

lgtm, but let's be cautious in case it triggers a layouttest failure.

[reed1, 2016-02-23 15:36:33]

fyi -- I'm surprised this doesn't generate a warning about double/float stuff

[mtklein, 2016-02-23 15:48:29]

On 2016/02/23 15:36:33, reed1 wrote:
> fyi -- I'm surprised this doesn't generate a warning about double/float stuff

Yeah, again, that warning only triggers for literals when 'x' and 'xf' represent
different values.
It shouldn't ever complain about a reasonably-sized power of two.

[dogben, 2016-02-24 18:38:16]

On 2016/02/23 at 15:35:36, reed wrote:
> lgtm, but let's be cautious in case it triggers a layouttest failure.

Layout tests pass locally.

[dogben, 2016-02-24 18:38:18]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2016-02-24 18:38:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723483004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723483004/1

[commit-bot: I haz the power, 2016-02-24 18:57:49]

Description was changed from

==========
Round to nearest in ScalarTo256.

This is a followup to https://codereview.chromium.org/1693683002 per discussion
on https://codereview.chromium.org/1691403002.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Round to nearest in ScalarTo256.

This is a followup to https://codereview.chromium.org/1693683002 per discussion
on https://codereview.chromium.org/1691403002.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/43437c2f1928073a30c2bab6d32df854658235ec
==========

[commit-bot: I haz the power, 2016-02-24 18:57:50]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/43437c2f1928073a30c2bab6d32df854658235ec