Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 1723483002: Revert of ix misc asserts and checks found by fuzzer (Closed)

Created:
4 years, 10 months ago by reed1
Modified:
4 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1723473002/ ) Reason for revert: need to not land the canvas change yet Original issue's description: > Reland of ix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713413002/ ) > > Reason for revert: > deps instability seemingly fixed. trying again. > > Original issue's description: > > Revert of fix misc asserts and checks found by fuzzer (patchset #1 id:1 of https://codereview.chromium.org/1713383002/ ) > > > > Reason for revert: > > speculative deps-roll fix > > > > Original issue's description: > > > fix misc asserts and checks found by fuzzer > > > > > > BUG=skia: > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713383002 > > > > > > TBR=robertphilips > > > > > > Committed: https://skia.googlesource.com/skia/+/00bea4ad310c4ec4dd95809b47ce3fbfa8fd0e1e > > > > TBR=robertphillips@google.com > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/d98ef6377269e3596423225ab922301ed40529a0 > > TBR=robertphillips@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/75a73297cb44c65a9efcf5f212854cb457140e34 TBR=robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1d524699274bc1d4c43af0c3d0ae269b8c37a3bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -84 lines) Patch
M include/core/SkPathEffect.h View 2 chunks +2 lines, -14 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 2 chunks +5 lines, -1 line 0 comments Download
M include/effects/SkDashPathEffect.h View 3 chunks +4 lines, -3 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +32 lines, -36 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of ix misc asserts and checks found by fuzzer
4 years, 10 months ago (2016-02-22 13:57:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723483002/1
4 years, 10 months ago (2016-02-22 13:57:26 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 13:57:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d524699274bc1d4c43af0c3d0ae269b8c37a3bb

Powered by Google App Engine
This is Rietveld 408576698