content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 1723473003: Remove limitation that renderer can't send sync IPCs to the UI thread in the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 1723473003: Remove limitation that renderer can't send sync IPCs to the UI thread in the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index 2bedae354ae3890dabb839d04b47dc12d5a51e44..0cea53190f852a49788f6fb82474127f0d0e6ec6 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -674,8 +674,6 @@ TEST_F(RenderFrameHostManagerTest, FilterMessagesWhileSwappedOut) {

base::string16 unused;

FrameHostMsg_RunBeforeUnloadConfirm before_unload_msg(

ntp_rfh->GetRoutingID(), kChromeURL, msg, false, &result, &unused);

- // Enable pumping for check in BrowserMessageFilter::CheckCanDispatchOnUI.

- before_unload_msg.EnableMessagePumping();

EXPECT_TRUE(ntp_rfh->OnMessageReceived(before_unload_msg));

EXPECT_TRUE(ntp_process_host->sink().GetUniqueMessageMatching(IPC_REPLY_ID));

« no previous file with comments | « no previous file | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »