Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1723473003: Remove limitation that renderer can't send sync IPCs to the UI thread in the browser. (Closed)

Created:
4 years, 10 months ago by jam
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove limitation that renderer can't send sync IPCs to the UI thread in the browser. Now that we don't have windowed NPAPI plugins, this deadlock doesn't exist anymore. BUG=493212 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/17acb78d1b36d7ff5ba7dcc4f04c853241f54aa3 Cr-Commit-Position: refs/heads/master@{#377166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jam
4 years, 10 months ago (2016-02-23 22:24:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723473003/1
4 years, 10 months ago (2016-02-23 22:42:36 UTC) #5
Tom Sepez
LGTM on the mechanics of deleting code; I didn't confirm whether the premise was correct.
4 years, 10 months ago (2016-02-23 22:51:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723473003/1
4 years, 10 months ago (2016-02-23 23:24:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 01:15:11 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:16:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17acb78d1b36d7ff5ba7dcc4f04c853241f54aa3
Cr-Commit-Position: refs/heads/master@{#377166}

Powered by Google App Engine
This is Rietveld 408576698