Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1723453002: Revert of GN: Normalize the build directory path (Closed)

Created:
4 years, 10 months ago by hashimoto
Modified:
4 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GN: Normalize the build directory path (patchset #1 id:1 of https://codereview.chromium.org/1707293002/ ) Reason for revert: Doesn't work when the build directory does not exit. Original issue's description: > GN: Normalize the build directory path > > BUG=586906 > TEST=ln -s /tmp out_tmp && out/gn/gn gen //out_tmp/Release > > Committed: https://crrev.com/62b5ce373ce17228a3c06f3e32ff329180e89921 > Cr-Commit-Position: refs/heads/master@{#376288} TBR=brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=586906 Committed: https://crrev.com/14bbbf277bf50e0103891dd2ad80aa8d091fe6d5 Cr-Commit-Position: refs/heads/master@{#376710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -35 lines) Patch
M tools/gn/setup.cc View 3 chunks +3 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hashimoto
Created Revert of GN: Normalize the build directory path
4 years, 10 months ago (2016-02-22 09:39:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723453002/1
4 years, 10 months ago (2016-02-22 09:39:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723453002/1
4 years, 10 months ago (2016-02-22 10:03:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 10:11:37 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 10:12:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14bbbf277bf50e0103891dd2ad80aa8d091fe6d5
Cr-Commit-Position: refs/heads/master@{#376710}

Powered by Google App Engine
This is Rietveld 408576698