First step of support for parsing and ignoring generic methods.

pkg/compiler/lib/src/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.compiler_base;
 
 import 'dart:async' show
     EventSink,
     Future;
 
@@ skipping 74 matching lines @@
 import 'mirrors_used.dart' show
     MirrorUsageAnalyzerTask;
 import 'common/names.dart' show
     Selectors;
 import 'null_compiler_output.dart' show
     NullCompilerOutput,
     NullSink;
 import 'parser/diet_parser_task.dart' show
     DietParserTask;
 import 'parser/element_listener.dart' show
+    ParserOptions,
     ScannerOptions;
 import 'parser/parser_task.dart' show
     ParserTask;
 import 'patch_parser.dart' show
     PatchParserTask;
 import 'resolution/registry.dart' show
     ResolutionRegistry;
 import 'resolution/resolution.dart' show
     ResolverTask;
 import 'resolution/tree_elements.dart' show
@@ skipping 90 matching lines @@
   final bool enableUserAssertions;
   final bool trustTypeAnnotations;
   final bool trustPrimitives;
   final bool trustJSInteropTypeAnnotations;
   final bool disableTypeInferenceFlag;
   final Uri deferredMapUri;
   final bool dumpInfo;
   final bool useContentSecurityPolicy;
   final bool enableExperimentalMirrors;
   final bool enableAssertMessage;
+  final bool enableConditionalDirectives;
+  final bool enableGenericMethods;
 
   /**
    * The maximum size of a concrete type before it widens to dynamic during
    * concrete type inference.
    */
   final int maxConcreteTypeSize;
   final bool analyzeAllFlag;
   final bool analyzeOnly;
 
   /// If true, disable tree-shaking for the main script.
@@ skipping 232 matching lines @@
             this.preserveComments: false,
             this.useCpsIr: false,
             this.useFrequencyNamer: false,
             this.verbose: false,
             this.sourceMapUri: null,
             this.outputUri: null,
             this.buildId: UNDETERMINED_BUILD_ID,
             this.deferredMapUri: null,
             this.dumpInfo: false,
             bool useStartupEmitter: false,
-            bool enableConditionalDirectives: false,
+            this.enableConditionalDirectives: false,
+            this.enableGenericMethods: false,
             this.useContentSecurityPolicy: false,
             bool hasIncrementalSupport: false,
             this.enableExperimentalMirrors: false,
             this.enableAssertMessage: false,
             this.allowNativeExtensions: false,
             this.generateCodeWithCompileTimeErrors: false,
             this.testMode: false,
             DiagnosticOptions diagnosticOptions,
             api.CompilerOutput outputProvider,
             List<String> strips: const []})
@@ skipping 42 matching lines @@
       if (dumpInfo) {
         throw new ArgumentError('--dump-info is not supported for dart2dart.');
       }
     }
 
     tasks = [
       libraryLoader = new LibraryLoaderTask(this),
       serialization = new SerializationTask(this),
       scanner = new ScannerTask(this),
       dietParser = new DietParserTask(
-          this, enableConditionalDirectives: enableConditionalDirectives),
+          this,
+          enableConditionalDirectives: enableConditionalDirectives,
+          enableGenericMethods: enableGenericMethods),

[Johnni Winther, 2016/02/29 10:18:45]

Pass [parserOptions] instead. (Also below)

[eernst, 2016/03/09 16:28:13]

Right, it is clearly better to keep multiple options together in a single
options object, so this means that it will replace both `enable..` arguments.
The `enableConditionalDirectives` argument is false by default here, and the
same holds for the only call site, so it should not change the semantics. The
`parserOptions` argument will be mandatory, such that we avoid the
complexity/redundancy of building a default one as well as providing default
values for each of its fields.

Done.

       parser = new ParserTask(
-          this, enableConditionalDirectives: enableConditionalDirectives),
+          this,
+          enableConditionalDirectives: enableConditionalDirectives,
+          enableGenericMethods: enableGenericMethods),
       patchParser = new PatchParserTask(
-          this, enableConditionalDirectives: enableConditionalDirectives),
+          this,
+          enableConditionalDirectives: enableConditionalDirectives,
+          enableGenericMethods: enableGenericMethods),
       resolver = new ResolverTask(this, backend.constantCompilerTask),
       closureToClassMapper = new closureMapping.ClosureTask(this),
       checker = new TypeCheckerTask(this),
       typesTask = new ti.TypesTask(this),
       constants = backend.constantCompilerTask,
       deferredLoadTask = new DeferredLoadTask(this),
       mirrorUsageAnalyzerTask = new MirrorUsageAnalyzerTask(this),
       enqueuer = new EnqueueTask(this),
       dumpInfoTask = new DumpInfoTask(this),
       reuseLibraryTask = new GenericTask('Reuse library', this),
@@ skipping 1642 matching lines @@
       if (cls.isPatch) {
         compiler.patchParser.parsePatchClassNode(cls);
       }
     });
   }
 
   ScannerOptions getScannerOptionsFor(Element element) {
     return new ScannerOptions(
       canUseNative: compiler.backend.canLibraryUseNative(element.library));
   }
+
+  @override
+  ParserOptions get parserOptions {
+    return new ParserOptions(
+        enableConditionalDirectives: compiler.enableConditionalDirectives,
+        enableGenericMethods: compiler.enableGenericMethods);
+  }
 }
 
 class GlobalDependencyRegistry extends EagerRegistry {
   final Compiler compiler;
   Setlet<Element> _otherDependencies;
 
   GlobalDependencyRegistry(this.compiler) : super('GlobalDependencies', null);
 
   // TODO(johnniwinther): Rename world/universe/enqueuer through out the
   // compiler.
   @override
   Enqueuer get world => compiler.enqueuer.codegen;
 
   void registerDependency(Element element) {
     if (element == null) return;
     if (_otherDependencies == null) {
       _otherDependencies = new Setlet<Element>();
     }
     _otherDependencies.add(element.implementation);
   }
 
   Iterable<Element> get otherDependencies {
     return _otherDependencies != null ? _otherDependencies : const <Element>[];
   }
 }