third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 1723353002: Add deprecation message for AppCache in insecure contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1723353002: Add deprecation message for AppCache in insecure contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Rebase on ToT Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/simple.txt ('k') | third_party/WebKit/Source/core/frame/OriginsUsingFeatures.h » ('j') | third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index 2b4fe9290a32a456b3dbe94d5db83c5a3a874b0f..c8ed59688cbbdaaa12f3fab2d79dff5a4efdca2d 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -270,6 +270,10 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)

case UseCounter::EncryptedMediaInsecureOrigin:

return "requestMediaKeySystemAccess() is deprecated on insecure origins in the specification. Support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

+ case UseCounter::ApplicationCacheManifestSelectInsecureOrigin:

+ case UseCounter::ApplicationCacheAPIInsecureOrigin:

+ return "Use of the Application Cache is deprecated on insecure origins. Support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";

case UseCounter::ElementCreateShadowRootMultiple:

return "Calling Element.createShadowRoot() for an element which already hosts a shadow root is deprecated. See https://www.chromestatus.com/features/4668884095336448 for more details.";