third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp - Issue 1723353002: Add deprecation message for AppCache in insecure contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp

Issue 1723353002: Add deprecation message for AppCache in insecure contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin.html ('K') | « third_party/WebKit/Source/core/frame/OriginsUsingFeatures.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp

diff --git a/third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp b/third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp

index 0b3ec59fbb1db4bbecc2cc8d5b42e8b4674f325c..696e8df1da8cf581a7240d7bd6cd6f2c53e15a20 100644

--- a/third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp

+++ b/third_party/WebKit/Source/core/frame/OriginsUsingFeatures.cpp

@@ -158,6 +158,10 @@ void OriginsUsingFeatures::Value::recordOriginToRappor(const String& origin)

Platform::current()->recordRappor("PowerfulFeatureUse.Host.GetUserMedia.Insecure", origin);

if (get(Feature::GetUserMediaSecureOrigin))

Platform::current()->recordRappor("PowerfulFeatureUse.Host.GetUserMedia.Secure", origin);

+ if (get(Feature::ApplicationCacheManifestSelectInsecureOrigin))

+ Platform::current()->recordRappor("PowerfulFeatureUse.Host.ApplicationCacheManifestSelect.Insecure", origin);

+ if (get(Feature::ApplicationCacheAPIInsecureOrigin))

+ Platform::current()->recordRappor("PowerfulFeatureUse.Host.ApplicationCacheAPI.Insecure", origin);

}

void OriginsUsingFeatures::Value::recordNameToRappor(const String& name)