src/ast/scopes.h - Issue 1723313002: [parser] Enforce module-specific identifier restriction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/scopes.h

Issue 1723313002: [parser] Enforce module-specific identifier restriction (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Relax assertion criteria Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/scopes.h

diff --git a/src/ast/scopes.h b/src/ast/scopes.h

index c3f7d5966545aca637aad7913c86ffb3cf511389..d35a20231519c77fb9a921bc33ac72e62feed411 100644

--- a/src/ast/scopes.h

+++ b/src/ast/scopes.h

@@ -243,7 +243,7 @@ class Scope: public ZoneObject {

// Set the language mode flag (unless disabled by a global flag).

void SetLanguageMode(LanguageMode language_mode) {

- DCHECK(!is_module_scope());

+ DCHECK(!is_module_scope() || is_strict(language_mode));

language_mode_ = language_mode;

}

« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | test/cctest/test-parsing.cc » ('J')