[parser] Enforce module-specific identifier restriction

src/ast/scopes.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_SCOPES_H_
 #define V8_AST_SCOPES_H_
 
 #include "src/ast/ast.h"
 #include "src/hashmap.h"
 #include "src/pending-compilation-error-handler.h"
@@ skipping 334 matching lines @@
   }
   bool outer_scope_calls_sloppy_eval() const {
     return outer_scope_calls_sloppy_eval_;
   }
   bool asm_module() const { return asm_module_; }
   bool asm_function() const { return asm_function_; }
 
   // Is this scope inside a with statement.
   bool inside_with() const { return scope_inside_with_; }
 
+  // Is this scope inside module code.
+  bool inside_module() const { return scope_inside_module_; }

[adamk, 2016/02/23 22:37:15]

Scope isn't the right place to put this, since it's not used at all in any Scope
analysis logic.

Can't this just be on Parser? There's no way to parse a module inside a module,
so for any given parser invocation, the options are:

1. We're parsing a module
2. We're parsing some other top-level program
3. We're parsing a function lazily, in which case it must have parsed
successfully the first time.

[mike3, 2016/02/24 16:20:54]

Acknowledged.

+
   // Does this scope access "arguments".
   bool uses_arguments() const { return scope_uses_arguments_; }
   // Does this scope access "super" property (super.foo).
   bool uses_super_property() const { return scope_uses_super_property_; }
   // Does this scope have the potential to execute declarations non-linearly?
   bool is_nonlinear() const { return scope_nonlinear_; }
 
   // Whether this needs to be represented by a runtime context.
   bool NeedsContext() const {
     // Catch and module scopes always have heap slots.
@@ skipping 281 matching lines @@
   // Map of function names to lists of functions defined in sloppy blocks
   SloppyBlockFunctionMap sloppy_block_function_map_;
 
   // Illegal redeclaration.
   Expression* illegal_redecl_;
 
   // Scope-specific information computed during parsing.
   //
   // This scope is inside a 'with' of some outer scope.
   bool scope_inside_with_;
+  // This scpope is inside module code
+  bool scope_inside_module_;
   // This scope contains a 'with' statement.
   bool scope_contains_with_;
   // This scope or a nested catch scope or with scope contain an 'eval' call. At
   // the 'eval' call site this scope is the declaration scope.
   bool scope_calls_eval_;
   // This scope uses "arguments".
   bool scope_uses_arguments_;
   // This scope uses "super" property ('super.foo').
   bool scope_uses_super_property_;
   // This scope contains an "use asm" annotation.
@@ skipping 163 matching lines @@
   AstValueFactory* ast_value_factory_;
   Zone* zone_;
 
   PendingCompilationErrorHandler pending_error_handler_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_AST_SCOPES_H_