Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 172313004: Remove unused AppKeepAliveService (Closed)

Created:
6 years, 10 months ago by James Cook
Modified:
6 years, 10 months ago
Reviewers:
Sam McNally, benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Remove unused AppKeepAliveService For app_shell (go/appshell) we need to remove the circular dependencies from src/apps back to src/chrome. AppKeepAliveService has dependencies on Chrome but is unused, so let's delete it instead of fixing it. BUG=326040 TEST=compiles TBR=erg@chromium.org for deleting an unused include from chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253695

Patch Set 1 #

Patch Set 2 : rebase (keep_alive_service) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -327 lines) Patch
D apps/app_keep_alive_service.h View 1 chunk +0 lines, -39 lines 0 comments Download
D apps/app_keep_alive_service.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
D apps/app_keep_alive_service_factory.h View 1 chunk +0 lines, -36 lines 0 comments Download
D apps/app_keep_alive_service_factory.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D apps/app_keep_alive_service_unittest.cc View 1 1 chunk +0 lines, -129 lines 0 comments Download
M apps/apps.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
James Cook
sammc, PTAL. I see from the bug that this code was disabled pending a design ...
6 years, 10 months ago (2014-02-22 15:11:43 UTC) #1
James Cook
Friendly ping?
6 years, 10 months ago (2014-02-25 18:13:00 UTC) #2
Sam McNally
+benwells
6 years, 10 months ago (2014-02-25 22:27:13 UTC) #3
benwells
On 2014/02/25 22:27:13, Sam McNally wrote: > +benwells lgtm, we (hopefully) will need this soon ...
6 years, 10 months ago (2014-02-25 22:28:33 UTC) #4
James Cook
On 2014/02/25 22:28:33, benwells wrote: > On 2014/02/25 22:27:13, Sam McNally wrote: > > +benwells ...
6 years, 10 months ago (2014-02-26 18:04:14 UTC) #5
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-02-26 18:05:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/172313004/120001
6 years, 10 months ago (2014-02-26 18:06:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 18:43:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 10 months ago (2014-02-26 18:43:38 UTC) #9
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 10 months ago (2014-02-26 23:28:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/172313004/120001
6 years, 10 months ago (2014-02-26 23:30:41 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-27 03:06:39 UTC) #12
Message was sent while issue was closed.
Change committed as 253695

Powered by Google App Engine
This is Rietveld 408576698