Make ElementTraversal / NodeTraversal classes for clarity

Make ElementTraversal / NodeTraversal classes for clarity

Make ElementTraversal / NodeTraversal classes for clarity and better
encapsulation. We can now make the templated functions private to make sure
they are not used outside the ElementTraversal / NodeTraversal classes.

R=adamk, eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167473

[adamk, 2014-02-19 17:23:03]

lgtm modulo inline keywords

https://codereview.chromium.org/172313003/diff/1/Source/core/dom/ElementTrave...
File Source/core/dom/ElementTraversal.h (right):

https://codereview.chromium.org/172313003/diff/1/Source/core/dom/ElementTrave...
Source/core/dom/ElementTraversal.h:37: static inline Element* firstWithin(const
ContainerNode& current) { return firstElementWithinTemplate(current); }
Aren't these 'inline' keywords redundant? My understanding is that functions
defined inside classes like this are implicitly inline.

https://codereview.chromium.org/172313003/diff/1/Source/core/dom/NodeTraversal.h
File Source/core/dom/NodeTraversal.h (right):

https://codereview.chromium.org/172313003/diff/1/Source/core/dom/NodeTraversa...
Source/core/dom/NodeTraversal.h:39: static inline Node* next(const Node&
current) { return traverseNextTemplate(current); }
ditto on inline keywords

[Inactive, 2014-02-19 17:54:47]

Yes, I moved the methods definitions and forgot to remove the inlines, sorry
about that.

I stripped them from the new patch set.

[Inactive, 2014-02-19 17:55:02]

The CQ bit was checked by ch.dumez@samsung.com

[adamk, 2014-02-19 17:56:03]

still lgtm :)

My brain will definitely be happier that these are now classes, and the ability
to make the helpers private is icing on the cake.

[commit-bot: I haz the power, 2014-02-19 22:04:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/172313003/80001

[commit-bot: I haz the power, 2014-02-19 23:09:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/172313003/80001

[commit-bot: I haz the power, 2014-02-20 07:38:49]

Change committed as 167473