Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1723123002: Update PIEX: Prepares support for uncompressed thumbnails (Closed)

Created:
4 years, 10 months ago by yujieqin
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, adaubert
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update PIEX: Prepares support for uncompressed thumbnails The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate. BUG=b/26894354 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723123002 Committed: https://skia.googlesource.com/skia/+/cf16e67f846cf56d1c32ffdb0b3f96598b166ebb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723123002/1
4 years, 10 months ago (2016-02-23 14:04:09 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-23 14:04:10 UTC) #4
yujieqin
4 years, 10 months ago (2016-02-23 14:06:40 UTC) #7
msarett
lgtm Can you elaborate on the commit message? I'm understanding that nothing should change right ...
4 years, 10 months ago (2016-02-23 14:10:32 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-23 14:17:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723123002/1
4 years, 10 months ago (2016-02-23 14:17:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cf16e67f846cf56d1c32ffdb0b3f96598b166ebb
4 years, 10 months ago (2016-02-23 14:18:16 UTC) #15
ebrauer
4 years, 10 months ago (2016-02-23 14:39:06 UTC) #16
Message was sent while issue was closed.
On 2016/02/23 14:10:32, msarett wrote:
> lgtm
> 
> Can you elaborate on the commit message?  I'm understanding that nothing
should
> change right now, but this will allow you to add a new feature?
> 
> Can/will nyc-dev be updated as well?

Currently we extended the API to prepare support for uncompressed images
(thumbnails from DngCreator). The old API persists until everything got updated.
The change will also be synced to nyc-dev.

Powered by Google App Engine
This is Rietveld 408576698