|
|
DescriptionUpdate PIEX: Prepares support for uncompressed thumbnails
The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate.
BUG=b/26894354
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723123002
Committed: https://skia.googlesource.com/skia/+/cf16e67f846cf56d1c32ffdb0b3f96598b166ebb
Patch Set 1 #Messages
Total messages: 16 (8 generated)
Description was changed from ========== Update PIEX: Prepares support for uncompressed thumbnails BUG=skia: ========== to ========== Update PIEX: Prepares support for uncompressed thumbnails BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by yujieqin@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723123002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-02-23 20:04 UTC
Description was changed from ========== Update PIEX: Prepares support for uncompressed thumbnails BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update PIEX: Prepares support for uncompressed thumbnails BUG=b/26894354 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
yujieqin@google.com changed reviewers: + msarett@google.com, scroggo@google.com
lgtm Can you elaborate on the commit message? I'm understanding that nothing should change right now, but this will allow you to add a new feature? Can/will nyc-dev be updated as well?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Update PIEX: Prepares support for uncompressed thumbnails BUG=b/26894354 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update PIEX: Prepares support for uncompressed thumbnails The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate. BUG=b/26894354 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by yujieqin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723123002/1
Message was sent while issue was closed.
Description was changed from ========== Update PIEX: Prepares support for uncompressed thumbnails The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate. BUG=b/26894354 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update PIEX: Prepares support for uncompressed thumbnails The new version of PIEX added new API for adding support to thumbnails. It also marks some old API as deprecate. BUG=b/26894354 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/cf16e67f846cf56d1c32ffdb0b3f96598b166ebb ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cf16e67f846cf56d1c32ffdb0b3f96598b166ebb
Message was sent while issue was closed.
On 2016/02/23 14:10:32, msarett wrote: > lgtm > > Can you elaborate on the commit message? I'm understanding that nothing should > change right now, but this will allow you to add a new feature? > > Can/will nyc-dev be updated as well? Currently we extended the API to prepare support for uncompressed images (thumbnails from DngCreator). The old API persists until everything got updated. The change will also be synced to nyc-dev. |