Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1723043002: Roll HarfBuzz to 1.2.1 (Closed)

Created:
4 years, 10 months ago by drott
Modified:
4 years, 10 months ago
Reviewers:
kojii, eae, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll HarfBuzz to 1.2.1 This release of HarfBuzz should help us with two important issues: non-fallback-path AAT shaping performance as well as cases where fallback fails due to ZWJ being shaped with the primary font. BUG=584655, 576989 R=eae,kojii,behdad Committed: https://crrev.com/aa0c4d1c5fa80154d0e9cab3df4c6aad4acb79d6 Cr-Commit-Position: refs/heads/master@{#377246}

Patch Set 1 #

Patch Set 2 : Revert mark strategy locally until issue is resolved in upstream #

Patch Set 3 : Include upstream ebd7431f824 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1281 lines, -322 lines) Patch
M third_party/harfbuzz-ng/NEWS View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-blob.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-common.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 15 chunks +114 lines, -93 lines 0 comments Download
A + third_party/harfbuzz-ng/src/hb-directwrite.h View 2 chunks +5 lines, -11 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-directwrite.cc View 1 chunk +827 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-graphite2.cc View 6 chunks +43 lines, -28 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-file-private.hh View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-head-table.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 9 chunks +89 lines, -47 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh View 3 chunks +15 lines, -15 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gdef-table.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 1 2 12 chunks +71 lines, -61 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-jstf-table.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 4 chunks +29 lines, -11 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-maxp-table.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 1 6 chunks +13 lines, -14 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-tag.cc View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode-private.hh View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723043002/1
4 years, 10 months ago (2016-02-23 09:30:40 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/177939)
4 years, 10 months ago (2016-02-23 10:46:48 UTC) #4
drott
Discussion about double quote rendering issue caused by font bug on the HarfBuzz list: https://lists.freedesktop.org/archives/harfbuzz/2016-February/005489.html
4 years, 10 months ago (2016-02-24 02:37:31 UTC) #5
eae
LGTM I trust your and behdads judgment with regards to the double quote issue.
4 years, 10 months ago (2016-02-24 02:40:42 UTC) #6
drott
Revert mark strategy locally until issue is resolved in upstream
4 years, 10 months ago (2016-02-24 04:31:56 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723043002/20001
4 years, 10 months ago (2016-02-24 04:37:54 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/185925)
4 years, 10 months ago (2016-02-24 06:57:59 UTC) #11
drott
Include upstream ebd7431f824
4 years, 10 months ago (2016-02-24 07:14:15 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723043002/40001
4 years, 10 months ago (2016-02-24 07:15:15 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 08:42:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723043002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723043002/40001
4 years, 10 months ago (2016-02-24 08:58:27 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 09:10:14 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/aa0c4d1c5fa80154d0e9cab3df4c6aad4acb79d6 Cr-Commit-Position: refs/heads/master@{#377246}
4 years, 10 months ago (2016-02-24 09:11:33 UTC) #22
drott
4 years, 10 months ago (2016-02-24 09:27:08 UTC) #23
Message was sent while issue was closed.
🙌

Powered by Google App Engine
This is Rietveld 408576698