iOS: Fix condition for use_analyze in ios recipe module.

iOS: Fix condition for use_analyze in ios recipe module.

Turns out the default value (enabled) is True, but when
use_analyze is set to 'false' in the JSON, the value becomes
a string 'false'. Fix this by changing the condition check.

This caused the WebRTC trybots to always use analyze, which
is not supported (fails).

TBR=smut@google.com
BUG=588590
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298919

[kjellander_chromium, 2016-02-23 09:03:28]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2016-02-23 09:03:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1723033003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1723033003/1

[commit-bot: I haz the power, 2016-02-23 09:06:17]

Description was changed from

==========
iOS: Fix condition for use_analyze in ios recipe module.

Turns out the default value (enabled) is True, but when
use_analyze is set to 'false' in the JSON, the value becomes
a string 'false'. Fix this by changing the condition check.

This caused the WebRTC trybots to always use analyze, which
is not supported (fails).

TBR=smut@google.com
BUG=588590
==========

to

==========
iOS: Fix condition for use_analyze in ios recipe module.

Turns out the default value (enabled) is True, but when
use_analyze is set to 'false' in the JSON, the value becomes
a string 'false'. Fix this by changing the condition check.

This caused the WebRTC trybots to always use analyze, which
is not supported (fails).

TBR=smut@google.com
BUG=588590

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298919
==========

[commit-bot: I haz the power, 2016-02-23 09:06:17]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298919

[smut, 2016-02-23 19:39:42]

This does not lgtm. It looks like your config is setting use_analyze to the
string "false" and not the Boolean false. You should revert this and change
lines like:
"use_analyze": "false",
to:
"use_analyze": false,
in your JSON files.

e.g.
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/build/ios/t...

[kjellander_chromium, 2016-02-23 20:08:33]

On 2016/02/23 19:39:42, smut wrote:
> This does not lgtm. It looks like your config is setting use_analyze to the
> string "false" and not the Boolean false. You should revert this and change
> lines like:
> "use_analyze": "false",
> to:
> "use_analyze": false,
> in your JSON files.
> 
> e.g.
>
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/build/ios/t...

Sorry about that; you're absolutely right.
I made https://codereview.webrtc.org/1728743002/ to fix the JSON, and will
revert this right after.

[kjellander_chromium, 2016-02-23 20:26:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1726853002/ by kjellander@chromium.org.

The reason for reverting is: Proper fix is done in the JSON files in
https://codereview.webrtc.org/1728743002/ which now is landed. Reverting this..