Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 172293004: Explicit conversions for Float32 array loads/stores. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed ARM register constraints Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 32847)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -2392,7 +2392,7 @@
}
-static intptr_t GetResultCidOfNative(const Function& function) {
+static intptr_t GetResultCidOfNativeFactory(const Function& function) {
const Class& function_class = Class::Handle(function.Owner());
if (function_class.library() == Library::TypedDataLibrary()) {
const String& function_name = String::Handle(function.name());
@@ -2435,8 +2435,11 @@
arguments,
owner()->ic_data_array());
if (node->function().is_native()) {
- const intptr_t result_cid = GetResultCidOfNative(node->function());
- call->set_result_cid(result_cid);
+ const intptr_t result_cid = GetResultCidOfNativeFactory(node->function());
+ if (result_cid != kDynamicCid) {
+ call->set_result_cid(result_cid);
+ call->set_is_native_list_factory(true);
+ }
}
ReturnDefinition(call);
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698