Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722913002: Remove uses of this->foo. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -211 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 10 chunks +19 lines, -22 lines 0 comments Download
M xfa/src/fgas/src/font/fx_stdfontmgr.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_caretimp.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 33 chunks +52 lines, -52 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_pagemgr_new.cpp View 1 5 chunks +7 lines, -7 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 1 46 chunks +90 lines, -98 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_objectacc_imp.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 10 months ago (2016-02-23 03:15:48 UTC) #2
Wei Li
LGTM
4 years, 10 months ago (2016-02-23 17:23:29 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-23 19:21:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9976672977d39fc5fe9df2b0110ed977d79609a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698