don't let weburl_loader_mock fallback for non-data urls

don't let weburl_loader_mock fallback for non-data urls

fixes here https://codereview.chromium.org/16831015/ need to land and
roll first.

R=jamesr@chromium.org
BUG=237267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208146

[scottmg, 2013-06-19 23:37:50]

https://codereview.chromium.org/17229012/diff/1/webkit/support/weburl_loader_...
File webkit/support/weburl_loader_mock.cc (right):

https://codereview.chromium.org/17229012/diff/1/webkit/support/weburl_loader_...
webkit/support/weburl_loader_mock.cc:62:
DCHECK(StartsWithASCII(request.url().spec().data(), "data:", false))
i couldn't find the thing to ask a WebURL what scheme it is?

[jamesr, 2013-06-19 23:41:49]

https://codereview.chromium.org/17229012/diff/1/webkit/support/weburl_loader_...
File webkit/support/weburl_loader_mock.cc (right):

https://codereview.chromium.org/17229012/diff/1/webkit/support/weburl_loader_...
webkit/support/weburl_loader_mock.cc:62:
DCHECK(StartsWithASCII(request.url().spec().data(), "data:", false))
On 2013/06/19 23:37:50, scottmg wrote:
> i couldn't find the thing to ask a WebURL what scheme it is?

use operator GURL() and ask for for its scheme(), or even better call SchemeIs()

[scottmg, 2013-06-20 01:57:29]

On 2013/06/19 23:41:49, jamesr wrote:
>
https://codereview.chromium.org/17229012/diff/1/webkit/support/weburl_loader_...
> File webkit/support/weburl_loader_mock.cc (right):
> 
>
https://codereview.chromium.org/17229012/diff/1/webkit/support/weburl_loader_...
> webkit/support/weburl_loader_mock.cc:62:
> DCHECK(StartsWithASCII(request.url().spec().data(), "data:", false))
> On 2013/06/19 23:37:50, scottmg wrote:
> > i couldn't find the thing to ask a WebURL what scheme it is?
> 
> use operator GURL() and ask for for its scheme(), or even better call
SchemeIs()

Done.

[jamesr, 2013-06-20 04:36:21]

lgtm

https://codereview.chromium.org/17229012/diff/5001/webkit/support/weburl_load...
File webkit/support/weburl_loader_mock.cc (right):

https://codereview.chromium.org/17229012/diff/5001/webkit/support/weburl_load...
webkit/support/weburl_loader_mock.cc:61: DCHECK(static_cast<const
GURL&>(request.url()).SchemeIs("data"))
oh C++. you so silly

[commit-bot: I haz the power, 2013-06-20 19:20:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17229012/5001

[commit-bot: I haz the power, 2013-06-20 20:55:08]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-06-20 20:59:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17229012/5001

[scottmg, 2013-06-21 04:21:13]

raaar, a new mock-fail got added here
https://chromiumcodereview.appspot.com/17436003 will have to fix and wait for
another roll.

[jamesr1, 2013-06-21 04:23:56]

Shade!
On Jun 20, 2013 9:21 PM, <scottmg@chromium.org> wrote:

> raaar, a new mock-fail got added here
>
https://chromiumcodereview.**appspot.com/17436003<https://chromiumcodereview....
have to fix and wait for
> another roll.
>
>
https://codereview.chromium.**org/17229012/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-06-24 01:32:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/17229012/5001

[commit-bot: I haz the power, 2013-06-24 06:05:19]

Change committed as 208146