 Chromium Code Reviews
 Chromium Code Reviews Issue 17229005:
  Convert UnaryOpStub to a HydrogenCodeStub  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 17229005:
  Convert UnaryOpStub to a HydrogenCodeStub  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/hydrogen.h | 
| diff --git a/src/hydrogen.h b/src/hydrogen.h | 
| index 6a49e5708de953eb5cb74e88906afe9526c18b79..1a78fb257f55fb570dc950dcaa01da2d6a8ca049 100644 | 
| --- a/src/hydrogen.h | 
| +++ b/src/hydrogen.h | 
| @@ -1015,6 +1015,9 @@ class HGraphBuilder { | 
| HValue* BuildCheckNonSmi(HValue* object); | 
| HValue* BuildCheckMap(HValue* obj, Handle<Map> map); | 
| + static Representation ToRepresentation(TypeInfo info); | 
| + static Representation ToRepresentation(Handle<Type> type); | 
| 
danno
2013/07/02 12:03:09
I think it makes sense to move ToRepresentation(Ha
 
oliv
2013/07/02 13:12:33
ok, right that is a better place to stick the meth
 | 
| + | 
| // Building common constructs | 
| HInstruction* BuildExternalArrayElementAccess( | 
| HValue* external_elements, | 
| @@ -1078,6 +1081,8 @@ class HGraphBuilder { | 
| HLoadNamedField* AddLoadElements(HValue *object, HValue *typecheck = NULL); | 
| + void AddSoftDeoptimize(); | 
| + | 
| class IfBuilder { | 
| public: | 
| explicit IfBuilder(HGraphBuilder* builder, | 
| @@ -1360,6 +1365,9 @@ class HGraphBuilder { | 
| ElementsKind kind, | 
| int length); | 
| + HInstruction* BuildUnaryMathOp( | 
| + HValue* value, Handle<Type> type, Token::Value token); | 
| + | 
| void BuildCompareNil( | 
| HValue* value, | 
| Handle<Type> type, | 
| @@ -1447,8 +1455,6 @@ class HOptimizedGraphBuilder: public HGraphBuilder, public AstVisitor { | 
| bool inline_bailout() { return inline_bailout_; } | 
| - void AddSoftDeoptimize(); | 
| - | 
| void Bailout(const char* reason); | 
| HBasicBlock* CreateJoin(HBasicBlock* first, | 
| @@ -1632,9 +1638,6 @@ class HOptimizedGraphBuilder: public HGraphBuilder, public AstVisitor { | 
| // to push them as outgoing parameters. | 
| template <class Instruction> HInstruction* PreProcessCall(Instruction* call); | 
| - static Representation ToRepresentation(TypeInfo info); | 
| - static Representation ToRepresentation(Handle<Type> type); | 
| - | 
| void SetUpScope(Scope* scope); | 
| virtual void VisitStatements(ZoneList<Statement*>* statements); |