src/ia32/full-codegen-ia32.cc - Issue 17229005: Convert UnaryOpStub to a HydrogenCodeStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 17229005: Convert UnaryOpStub to a HydrogenCodeStub (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: add some duckt tape for now to fix non-sse Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 11df938089335a8f96aaddbe5828bf66f875c59e..e055682fb1e277d260f2bff1c53385dda9cb57d7 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -4366,10 +4366,7 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {

void FullCodeGenerator::EmitUnaryOperation(UnaryOperation* expr,

const char* comment) {

Comment cmt(masm_, comment);

- bool can_overwrite = expr->expression()->ResultOverwriteAllowed();

- UnaryOverwriteMode overwrite =

- can_overwrite ? UNARY_OVERWRITE : UNARY_NO_OVERWRITE;

- UnaryOpStub stub(expr->op(), overwrite);

+ UnaryOpStub stub(expr->op());

// UnaryOpStub expects the argument to be in the

// accumulator register eax.

VisitForAccumulatorValue(expr->expression());