Convert UnaryOpStub to a HydrogenCodeStub

src/code-stubs-hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 732 matching lines @@
     if_nil.Else();
     if_nil.Return(graph()->GetConstant0());
   }
   if_nil.End();
   return continuation.IsTrueReachable()
       ? graph()->GetConstant1()
       : graph()->GetConstantUndefined();
 }
 
 
+Handle<Code> UnaryOpStub::GenerateCode() {
+  return DoGenerateCode(this);
+}
+
+
+HInstruction* UnaryOpStub::ToHInstruction(HValue* input,
+    Handle<Type> type, HGraphBuilder* builder, HContext* context) {
+  switch (operation_) {
+    default:
+      UNREACHABLE();
+    case Token::SUB: {
+        HInstruction* minus = HMul::New(builder->zone(), context,
+            input, builder->graph()->GetConstantMinus1());
+        if (type->Maybe(Type::Double())) {
+          // We have to force a double multiplication if we have seen double,
+          // otherwise we will deopt again.
+          minus->AssumeRepresentation(Representation::Double());

[danno, 2013/06/21 16:38:04]

Try to move this out with the other representation changes so that this code can
be shared 100% with hydrogen.

+        }
+        return minus;
+      }
+    case Token::BIT_NOT:
+      return new(builder->zone()) HBitNot(input);
+  }
+}
+
+
+template <>
+HValue* CodeStubGraphBuilder<UnaryOpStub>::BuildCodeInitializedStub() {
+  UnaryOpStub* stub = casted_stub();

[danno, 2013/06/21 16:38:04]

Please share this code with hydrogen, it should be identical to the inlined
instructions in the optimized code. We do this for other stubs by putting 

+  Handle<Type> type = stub->GetType(graph()->isolate());
+  HValue* input = GetParameter(0);
+
+  if (!type->Is(Type::Number())) {
+    // If we expect to see other things than Numbers, we will create a generic
+    // stub, which handles all numbers and calls into the runtime for the rest.
+    IfBuilder if_number(this);
+    if_number.If<HIsNumberAndBranch>(input);
+    if_number.Then();
+      HInstruction* res = stub->ToHInstruction(input, type, this, context());
+      if_number.Return(AddInstruction(res));
+    if_number.Else();
+      AddInstruction(new(zone()) HPushArgument(GetParameter(0)));
+      if_number.Return(AddInstruction(new(zone()) HCallConstantFunction(
+            stub->ToJSFunction(isolate()), 1)));
+    if_number.End();
+    return graph()->GetConstantUndefined();
+  }
+
+  if (type->Is(Type::Integer31())) {
+    AddInstruction(new(zone()) HCheckSmi(input));

[danno, 2013/06/21 16:38:04]

Try to avoid the explicit checks by using force representation here and below
for double.

+  } else if (type->Is(Type::Double())) {
+    AddInstruction(new(zone()) HCheckNonSmi(input));
+  }
+
+  return AddInstruction(stub->ToHInstruction(input, type, this, context()));
+}
+
+
 Handle<Code> CompareNilICStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 
 template <>
 HValue* CodeStubGraphBuilder<ToBooleanStub>::BuildCodeInitializedStub() {
   ToBooleanStub* stub = casted_stub();
 
   IfBuilder if_true(this);
   if_true.If<HBranch>(GetParameter(0), stub->GetTypes());
   if_true.Then();
     if_true.Return(graph()->GetConstant1());
   if_true.Else();
   if_true.End();
   return graph()->GetConstant0();
 }
 
 
 Handle<Code> ToBooleanStub::GenerateCode() {
   return DoGenerateCode(this);
 }
 
 
 } }  // namespace v8::internal