Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722873002: Remove many _CAPS structure names. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove many _CAPS structure names. They're technically not allowed because they are reserved for the preprocessor. Also get rid of LPC* typedefs along the way. Also provide a header for a data file containing many instance of these found along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d21cddaa7548584bfcebefe9a03e857fee3a846b

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Spelling #

Total comments: 4

Patch Set 4 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -272 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 3 chunks +5 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 1 chunk +0 lines, -12 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M core/src/fxcrt/extension.h View 1 chunk +3 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_listbox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/core/fwl_widget.h View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M xfa/include/fwl/theme/utils.h View 2 chunks +6 lines, -7 lines 0 comments Download
M xfa/include/fxfa/fxfa_basic.h View 1 2 6 chunks +43 lines, -51 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_document.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_script.h View 1 chunk +1 line, -1 line 0 comments Download
A xfa/src/fxfa/src/parser/xfa_basic_data.h View 1 chunk +48 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_basic_data.cpp View 1 2 3 17 chunks +23 lines, -21 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_basic_imp.h View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_basic_imp.cpp View 1 2 3 21 chunks +49 lines, -62 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_imp.cpp View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_document_serialize.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 1 2 3 21 chunks +34 lines, -38 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_objectacc_imp.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_parser_imp.cpp View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_imp.cpp View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp View 1 2 3 3 chunks +6 lines, -12 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_resolveprocessor.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_utils_imp.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, for review.
4 years, 10 months ago (2016-02-23 01:04:41 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_basic_imp.h File xfa/src/fxfa/src/parser/xfa_basic_imp.h (right): https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_basic_imp.h#newcode10 xfa/src/fxfa/src/parser/xfa_basic_imp.h:10: #include "xfa/src/fgas/include/fx_stm.h" not sorted https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp File xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp (right): ...
4 years, 10 months ago (2016-02-23 01:34:46 UTC) #3
Tom Sepez
https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_basic_imp.h File xfa/src/fxfa/src/parser/xfa_basic_imp.h (right): https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_basic_imp.h#newcode10 xfa/src/fxfa/src/parser/xfa_basic_imp.h:10: #include "xfa/src/fgas/include/fx_stm.h" On 2016/02/23 01:34:46, Lei Zhang wrote: > ...
4 years, 10 months ago (2016-02-23 18:07:56 UTC) #4
Tom Sepez
https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp File xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp (right): https://codereview.chromium.org/1722873002/diff/40001/xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp#newcode428 xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp:428: bRes = TRUE; On 2016/02/23 01:34:46, Lei Zhang wrote: ...
4 years, 10 months ago (2016-02-23 18:08:39 UTC) #5
Tom Sepez
4 years, 10 months ago (2016-02-23 18:11:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
d21cddaa7548584bfcebefe9a03e857fee3a846b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698