chrome/browser/ui/webui/signin/user_manager_screen_handler.cc - Issue 1722843002: MD user manager (html/js/css for create profile flow)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

Issue 1722843002: MD user manager (html/js/css for create profile flow) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments #2 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_user_manager/user_manager.js ('K') | « chrome/browser/ui/webui/signin/signin_create_profile_handler.cc ('k') | third_party/closure_compiler/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

index 10b3d4f9c9b11c6ca77fda2042584aae5d980102..1ea5094075688eb8a8884c1633eb413345b45afa 100644

--- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

+++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

@@ -371,7 +371,7 @@ void UserManagerScreenHandler::HandleInitialize(const base::ListValue* args) {

args->GetString(0, &url_hash_);

SendUserList();

- web_ui()->CallJavascriptFunction("cr.ui.Oobe.showUserManagerScreen",

+ web_ui()->CallJavascriptFunction("cr.ui.UserManager.showUserManagerScreen",

base::FundamentalValue(IsGuestModeEnabled()),

base::FundamentalValue(IsAddPersonEnabled()));

@@ -915,7 +915,7 @@ void UserManagerScreenHandler::ReportAuthenticationResult(

ProfileMetrics::SWITCH_PROFILE_UNLOCK);

} else {

web_ui()->CallJavascriptFunction(

- "cr.ui.Oobe.showSignInError",

+ "cr.ui.UserManager.showSignInError",

base::FundamentalValue(0),

base::StringValue(l10n_util::GetStringUTF8(

auth == ProfileMetrics::AUTH_FAILED_OFFLINE ?