Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: chrome/browser/resources/md_user_manager/user_manager.js

Issue 1722843002: MD user manager (html/js/css for create profile flow) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_user_manager/user_manager.js
diff --git a/chrome/browser/resources/user_manager/user_manager.js b/chrome/browser/resources/md_user_manager/user_manager.js
similarity index 69%
copy from chrome/browser/resources/user_manager/user_manager.js
copy to chrome/browser/resources/md_user_manager/user_manager.js
index 39d76d4764abe302a71089b17d7563c0322f5290..38253e82bb0d1a9e5a41334658c7a113bf0e218f 100644
--- a/chrome/browser/resources/user_manager/user_manager.js
+++ b/chrome/browser/resources/md_user_manager/user_manager.js
@@ -1,28 +1,26 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+
<include src="../../../../ui/login/screen.js">
<include src="../../../../ui/login/bubble.js">
<include src="../../../../ui/login/login_ui_tools.js">
<include src="../../../../ui/login/display_manager.js">
-<include src="control_bar.js">
<include src="../../../../ui/login/account_picker/screen_account_picker.js">
<include src="../../../../ui/login/account_picker/user_pod_row.js">
<include src="../../../../ui/login/resource_loader.js">
-<include src="user_manager_tutorial.js">
+
cr.define('cr.ui', function() {
var DisplayManager = cr.ui.login.DisplayManager;
- var UserManagerTutorial = cr.ui.login.UserManagerTutorial;
/**
- * Constructs an Out of box controller. It manages initialization of screens,
- * transitions, error messages display.
- * @extends {DisplayManager}
- * @constructor
+ * Constructs an Out of box controller. It manages initialization of screens,
+ * transitions, error messages display.
+ * @constructor
+ * @extends {DisplayManager}
*/
- function Oobe() {
- }
+ function Oobe() {}
cr.addSingletonGetter(Oobe);
@@ -32,28 +30,24 @@ cr.define('cr.ui', function() {
/**
* Shows the given screen.
- * @param {bool} showGuest Whether the 'Browse as Guest' button is displayed.
- * @param {bool} showAddPerson Whether the 'Add Person' button is displayed.
+ * @param {boolean} showGuest True if 'Browse as Guest' button should be
+ * displayed.
+ * @param {boolean} showAddPerson True if 'Add Person' button should be
+ * displayed.
*/
Oobe.showUserManagerScreen = function(showGuest, showAddPerson) {
Oobe.getInstance().showScreen({id: 'account-picker',
data: {disableAddUser: false}});
- // The ChromeOS account-picker will hide the AddUser button if a user is
- // logged in and the screen is "locked", so we must re-enabled it
- $('add-user-header-bar-item').hidden = false;
-
// Hide control options if the user does not have the right permissions.
- $('guest-user-button').hidden = !showGuest;
- $('add-user-button').hidden = !showAddPerson;
- $('login-header-bar').hidden = false;
+ var controlBar = document.querySelector('control-bar');
+ controlBar.showGuest = showGuest;
+ controlBar.showAddPerson = showAddPerson;
// Disable the context menu, as the Print/Inspect element items don't
// make sense when displayed as a widget.
document.addEventListener('contextmenu', function(e) {e.preventDefault();});
- var hash = window.location.hash;
- if (hash && hash == '#tutorial')
- UserManagerTutorial.startTutorial();
+ // TODO(mahmadi): start the tutorial if the location hash is #tutorial.
};
/**
@@ -73,7 +67,7 @@ cr.define('cr.ui', function() {
/**
* Shows signin UI.
- * @param {string} opt_email An optional email for signin UI.
+ * @param {string=} opt_email An optional email for signin UI.
*/
Oobe.showSigninUI = function(opt_email) {
DisplayManager.showSigninUI(opt_email);
@@ -81,7 +75,7 @@ cr.define('cr.ui', function() {
/**
* Shows sign-in error bubble.
- * @param {number} loginAttempts Number of login attemps tried.
+ * @param {number} loginAttempts Number of login attempts tried.
* @param {string} message Error message to show.
* @param {string} link Text to use for help link.
* @param {number} helpId Help topic Id associated with help link.
@@ -113,11 +107,9 @@ cr.define('cr.ui', function() {
/**
* Show the user manager tutorial
- * @param {string} email The user's email, if signed in.
- * @param {string} displayName The user's display name.
*/
Oobe.showUserManagerTutorial = function() {
- UserManagerTutorial.startTutorial();
+ // TODO(mahmadi): start the tutorial.
};
// Export
@@ -131,14 +123,8 @@ cr.define('UserManager', function() {
function initialize() {
cr.ui.login.DisplayManager.initialize();
- cr.ui.login.UserManagerTutorial.initialize();
login.AccountPickerScreen.register();
cr.ui.Bubble.decorate($('bubble'));
- login.HeaderBar.decorate($('login-header-bar'));
-
- // Hide the header bar until the showUserManagerMethod can apply function
- // parameters that affect widget visiblity.
- $('login-header-bar').hidden = true;
chrome.send('userManagerInitialize', [window.location.hash]);
}

Powered by Google App Engine
This is Rietveld 408576698