chrome/browser/resources/md_user_manager/user_manager_pages.html - Issue 1722843002: MD user manager (html/js/css for create profile flow)

Side by Side Diff: chrome/browser/resources/md_user_manager/user_manager_pages.html

Issue 1722843002: MD user manager (html/js/css for create profile flow) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments #3 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_user_manager/user_manager.js ('K') | « chrome/browser/resources/md_user_manager/user_manager_pages.css ('k') | chrome/browser/resources/md_user_manager/user_manager_pages.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 <link rel="import" href="chrome://md-user-manager/create_profile.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/slide-from-left-animation.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/slide-right-animation.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani mated-pages.html">

1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">	5 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/fade-in-animation.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/fade-out-animation.html">

5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/slide-from-left-animation.html">

6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/slide-from-right-animation.html">

7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/slide-left-animation.html">

8 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/animatio ns/slide-right-animation.html">

9 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">

10 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani mated-pages.html">

11 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani mation-runner-behavior.html">

12	6

13 <dom-module id="settings-animated-pages">	7 <dom-module id="user-manager-pages">

14 <link rel="import" type="css" href="settings_animated_pages.css">	8 <link rel="import" type="css"

	9 href="chrome://md-user-manager/user_manager_pages.css">

15 <template>	10 <template>

16 <neon-animated-pages id="animatedPages" attr-for-selected="id">	11 <neon-animated-pages id="animatedPages" attr-for-selected="id"

17 <content select="*"></content>	12 selected="[[selectedPage_]]" entry-animation="slide-from-left-animation"

	13 exit-animation="slide-right-animation">

	14 <div id="create-user-page">

	15 <template is="dom-if" if="[[isPageVisible_(selectedPage_, 'create-user-p age')]]" restamp>
	Dan Beam 2016/03/08 01:18:16 nit: <template is="dom-if" if="... long condi nit: <template is="dom-if" if="... long conditional ..."> why [restamp]? so it actually gets unrendered? Moe 2016/03/08 15:47:34 Without 'restamp' create-profile won't get detache Show quoted text On 2016/03/08 01:18:16, Dan Beam wrote: > nit: > > <template is="dom-if" > if="... long conditional ..."> > > why [restamp]? so it actually gets unrendered? Without 'restamp' create-profile won't get detached from the DOM and webui listeners won't get unregistered in WebUIListenerBehavior. I followed settings/basic_page/basic_page.html as an example.
	16 <create-profile></create-profile>

	17 </template>

	18 </div>

	19 <div id="user-pods-page">

	20 <template is="dom-if" if="[[isPageVisible_(selectedPage_, 'user-pods-pag e')]]">

	21 <content></content>

	22 </template>

	23 </div>

18 </neon-animated-pages>	24 </neon-animated-pages>

19 </template>	25 </template>

20 <script src="settings_animated_pages.js"></script>	26 <script src="chrome://md-user-manager/user_manager_pages.js"></script>

21 </dom-module>	27 </dom-module>

OLD	NEW