chrome/browser/resources/md_user_manager/control_bar.html - Issue 1722843002: MD user manager (html/js/css for create profile flow)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_user_manager/control_bar.html

Issue 1722843002: MD user manager (html/js/css for create profile flow) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments #3 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_user_manager/control_bar.css ('k') | chrome/browser/resources/md_user_manager/control_bar.js » ('j') | chrome/browser/resources/md_user_manager/user_manager.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://md-user-manager/profile_api.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	5

	6 <dom-module id="control-bar">

	7 <!-- TODO(mahmadi): this format is deprecated. Change to the new

	8 "shared styles" format. -->

	9 <link rel="import" type="css" href="chrome://md-user-manager/control_bar.css">

	10 <template>

	11 <div id="login-header-bar"

	12 class="login-header-bar layout horizontal end-justified">

	13 <div id="logo"></div>

	14 <paper-button id="guest-user-button" on-click="handleGuestClick_"
	Dan Beam 2016/03/08 01:18:16 we generally use on-tap instead we generally use on-tap instead Dan Beam 2016/03/08 01:18:16 nit: onGuestUserButtonClick_ (or Tap_) nit: onGuestUserButtonClick_ (or Tap_) Moe 2016/03/08 15:47:34 Done. Show quoted text On 2016/03/08 01:18:16, Dan Beam wrote: > we generally use on-tap instead Done. Moe 2016/03/08 15:47:34 I have the events and their handler names fixed in Show quoted text On 2016/03/08 01:18:16, Dan Beam wrote: > nit: onGuestUserButtonClick_ (or Tap_) I have the events and their handler names fixed in the other CL that's based on this. Will go ahead and fix them here as well.
	15 i18n-content="browseAsGuest" hidden="[[!showGuest]]"></paper-button>

	16 <paper-button id="add-user-button" on-click="handleAddUserClick_"
	Dan Beam 2016/03/08 01:18:16 nit: onAddUserButtonClick_ (or Tap_) nit: onAddUserButtonClick_ (or Tap_) Moe 2016/03/08 15:47:34 Done. Show quoted text On 2016/03/08 01:18:16, Dan Beam wrote: > nit: onAddUserButtonClick_ (or Tap_) Done.
	17 i18n-content="addUser" hidden="[[!showAddPerson]]"></paper-button>

	18 </div>

	19 </template>

	20 <script src="chrome://md-user-manager/control_bar.js"></script>

	21 </dom-module>

OLD	NEW