chrome/browser/resources/md_user_manager/user_manager.html - Issue 1722843002: MD user manager (html/js/css for create profile flow)

Side by Side Diff: chrome/browser/resources/md_user_manager/user_manager.html

Issue 1722843002: MD user manager (html/js/css for create profile flow) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_user_manager/profile_api.js ('K') | « chrome/browser/resources/md_user_manager/user_manager.css ('k') | chrome/browser/resources/md_user_manager/user_manager.js » ('j') | chrome/browser/resources/md_user_manager/user_manager.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html i18n-values="build:buildType;

	3 dir:textdirection;

	4 lang:language;

	5 screen:screenType">

	6 <head>

	7 <meta charset="utf-8">

	8 <meta name="google" value="notranslate">

	9 <title i18n-content="title"></title>

	10

	11 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
	Dan Beam 2016/03/02 23:19:24 why are you using chrome_shared.css? this applies why are you using chrome_shared.css? this applies to a previous design style and probably shouldn't be used in Material Design style pages Moe 2016/03/03 18:05:46 Done. Show quoted text On 2016/03/02 23:19:24, Dan Beam wrote: > why are you using chrome_shared.css? this applies to a previous design style > and probably shouldn't be used in Material Design style pages Done.
	12 <link rel="stylesheet" href="../../../../ui/login/account_picker/screen_accoun t_picker.css">

	13 <link rel="stylesheet" href="../../../../ui/login/account_picker/user_pod_row. css">

	14 <link rel="stylesheet" href="../../../../ui/login/bubble.css">

	15 <link rel="stylesheet" href="../../../../ui/login/oobe.css">

	16 <link rel="stylesheet" href="../../../../ui/login/screen_container.css">

	17 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

	18 <link rel="stylesheet" href="user_manager.css">

	19

	20 <link rel="import" href="chrome://md-user-manager/control_bar.html">

	21 <link rel="import" href="chrome://md-user-manager/create_profile.html">

	22 <link rel="import" href="chrome://md-user-manager/strings.html">

	23 <link rel="import" href="chrome://md-user-manager/user_manager_pages.html">

	24 <link rel="import" href="chrome://resources/html/action_link.html">
	Dan Beam 2016/03/02 23:19:24 there seem to be transitive dependencies in this l there seem to be transitive dependencies in this list. please only list direct dependencies as imports at each level Moe 2016/03/03 18:05:46 From the list, I removed load_time_data.html and a Show quoted text On 2016/03/02 23:19:24, Dan Beam wrote: > there seem to be transitive dependencies in this list. please only list direct > dependencies as imports at each level From the list, I removed load_time_data.html and action_link.html which were not needed. The rest are dependencies of what's included in the user_manager.js. These used to be included as external JS scripts and I converted as many as I could to html dependencies to avoid having them included multiple times.
	25 <link rel="import" href="chrome://resources/html/cr.html">

	26 <link rel="import" href="chrome://resources/html/cr/event_target.html">

	27 <link rel="import" href="chrome://resources/html/cr/ui.html">

	28 <link rel="import" href="chrome://resources/html/cr/ui/menu.html">

	29 <link rel="import" href="chrome://resources/html/cr/ui/menu_button.html">

	30 <link rel="import" href="chrome://resources/html/cr/ui/menu_item.html">

	31 <link rel="import" href="chrome://resources/html/i18n_template.html">

	32 <link rel="import" href="chrome://resources/html/load_time_data.html">

	33 <link rel="import" href="chrome://resources/html/util.html">

	34 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html" >

	35 </head>

	36 <body class="oobe-display" unresolved>
	Dan Beam 2016/03/02 23:19:24 why is oobe again mentioned here? why is oobe again mentioned here? Moe 2016/03/03 18:05:46 a lot of the rules in src/ui/login/screen_containe Show quoted text On 2016/03/02 23:19:24, Dan Beam wrote: > why is oobe again mentioned here? a lot of the rules in src/ui/login/screen_container.css assume '.oobe-display' on the body as well things like '#outer-container', '#inner-container', and '#oobe' IDs which you will find in this html. Until we fork and redo the userpods there really is no escaping having these here. I understand this page is a weird hybrid of Polymer and traditional webui page at its current state, but redoing the user pods right now is hard to justify, given that this needs go out before the new settings page.
	37 <user-manager-pages>

	38 <div id="user-pods-page">

	39 <div id="outer-container">

	40 <div id="oobe" class="faded">

	41 <div id="inner-container">

	42 <div id="step-logo" hidden>

	43 <div id="header-sections"></div>

	44 </div>

	45 <include src="../../../../ui/login/account_picker/screen_account_pic ker.html">

	46 </div>

	47 </div>

	48 </div>

	49 <div id="bubble" class="bubble faded" hidden></div>

	50 <control-bar></control-bar>

	51 <include src="../../../../ui/login/account_picker/user_pod_template.html">

	52 </div>

	53 <create-profile id="create-user-page"></create-profile>

	54 </user-manager-pages>

	55 <!-- framework imports -->

	56 <!-- as per chrome/browser/resources/chromeos/login/login_resources.html -->

	57 <script src="chrome://resources/js/event_tracker.js"></script>

	58 <script src="chrome://resources/js/cr/ui/array_data_model.js"></script>

	59 <script src="chrome://resources/js/cr/ui/list_selection_controller.js"></scrip t>

	60 <script src="chrome://resources/js/cr/ui/list_selection_model.js"></script>

	61 <script src="chrome://resources/js/cr/ui/list_single_selection_model.js"></scr ipt>

	62 <script src="chrome://resources/js/cr/ui/list.js"></script>

	63 <script src="chrome://resources/js/cr/ui/list_item.js"></script>

	64 <script src="chrome://resources/js/cr/ui/grid.js"></script>

	65 <script src="user_manager.js"></script>

	66 </body>

	67 </html>

OLD	NEW