url/ipc/BUILD.gn - Issue 1722773002: Mustash: Move GURL ParamTraits to url/ipc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: url/ipc/BUILD.gn

Issue 1722773002: Mustash: Move GURL ParamTraits to url/ipc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//testing/test.gni")

	6

	7 source_set("url_ipc") {

	8 sources = [

	9 "url_param_traits.cc",

	10 "url_param_traits.h",

	11 ]
	brettw 2016/02/22 22:07:15 This should depend on "//url" and "//ipc", This should depend on "//url" and "//ipc", Mark Dittmer 2016/02/23 15:13:54 Done. Show quoted text On 2016/02/22 22:07:15, brettw wrote: > This should depend on "//url" and "//ipc", Done.
	12 }

	13

	14 test("url_ipc_unittests") {

	15 sources = [

	16 "url_param_traits_unittest.cc",
	brettw 2016/02/22 22:43:40 Actually, I think this can be compiled in to url_u Actually, I think this can be compiled in to url_unittests in the parent directory. Adding another target here will just be a big headache (have to configure the bots to run it) and there's no reason why a unit test file couldn't just depend on IPC. What I would do is keep this target as-is but change to a source_set, then add this source_set to the deps of //url:url_unittests Mark Dittmer 2016/02/23 15:13:54 Done. Show quoted text On 2016/02/22 22:43:40, brettw wrote: > Actually, I think this can be compiled in to url_unittests in the parent > directory. Adding another target here will just be a big headache (have to > configure the bots to run it) and there's no reason why a unit test file > couldn't just depend on IPC. > > What I would do is keep this target as-is but change to a source_set, then add > this source_set to the deps of //url:url_unittests Done.
	17 ]

	18

	19 deps = [

	20 "//base",

	21 "//testing/gtest",

	22 "//url:url",
	brettw 2016/02/22 22:07:15 This can just be "//url", This can just be "//url", Mark Dittmer 2016/02/23 15:13:54 N/A with removal. Show quoted text On 2016/02/22 22:07:15, brettw wrote: > This can just be "//url", N/A with removal.
	23 ]

	24 }

OLD	NEW

« no previous file with comments | « url/BUILD.gn ('k') | url/ipc/url_param_traits.h » ('j') | url/ipc/url_param_traits.h » ('J')