Mustash: Move GURL ParamTraits to url/ipc

Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}

Committed: https://crrev.com/67b71ea2e11563a4c0363e1dce4e266cebcd063a
Cr-Commit-Position: refs/heads/master@{#379122}

[Mark Dittmer, 2016-02-22 20:04:28]

Description was changed from

==========
Move GRUL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
==========

to

==========
Move GRUL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mark Dittmer, 2016-02-22 20:06:52]

Description was changed from

==========
Move GRUL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move GRUL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mark Dittmer, 2016-02-22 20:06:52]

markdittmer@chromium.org changed reviewers:
+ brettw@chromium.org, fsamuel@chromium.org, piman@chromium.org

[piman, 2016-02-22 20:18:58]

lgtm

[brettw, 2016-02-22 22:07:15]

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn
File url/ipc/BUILD.gn (right):

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn#newcode11
url/ipc/BUILD.gn:11: ]
This should depend on "//url" and "//ipc",

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn#newcode22
url/ipc/BUILD.gn:22: "//url:url",
This can just be "//url",

https://codereview.chromium.org/1722773002/diff/1/url/ipc/url_param_traits.h
File url/ipc/url_param_traits.h (right):

https://codereview.chromium.org/1722773002/diff/1/url/ipc/url_param_traits.h#...
url/ipc/url_param_traits.h:1: // Copyright (c) 2016 The Chromium Authors. All
rights reserved.
New copyright notice has no "(c)". Also for other new files.

https://codereview.chromium.org/1722773002/diff/1/url/ipc/url_param_traits.h#...
url/ipc/url_param_traits.h:10: #include "url/url_export.h"
Delete this line and the usage of URL_EXPORT below. This isn't a component.

https://codereview.chromium.org/1722773002/diff/1/url/url.gyp
File url/url.gyp (right):

https://codereview.chromium.org/1722773002/diff/1/url/url.gyp#newcode27
url/url.gyp:27: 'ipc/url_param_traits.cc',
This should be in a separate target like GN. That target would depend on the IPC
target.

[brettw, 2016-02-22 22:43:40]

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn
File url/ipc/BUILD.gn (right):

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn#newcode16
url/ipc/BUILD.gn:16: "url_param_traits_unittest.cc",
Actually, I think this can be compiled in to url_unittests in the parent
directory. Adding another target here will just be a big headache (have to
configure the bots to run it) and there's no reason why a unit test file
couldn't just depend on IPC.

What I would do is keep this target as-is but change to a source_set, then add
this source_set to the deps of //url:url_unittests

[jsbell, 2016-02-22 23:43:40]

Description was changed from

==========
Move GRUL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move GURL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mark Dittmer, 2016-02-23 15:13:53]

markdittmer@chromium.org changed reviewers:
+ tsepez@chromium.org

[Mark Dittmer, 2016-02-23 15:13:54]

+tsepez for owners review: *_messages.h and common_param_traits. PTAL.

Fixed gn build targets.

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn
File url/ipc/BUILD.gn (right):

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn#newcode11
url/ipc/BUILD.gn:11: ]
On 2016/02/22 22:07:15, brettw wrote:
> This should depend on "//url" and "//ipc",

Done.

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn#newcode16
url/ipc/BUILD.gn:16: "url_param_traits_unittest.cc",
On 2016/02/22 22:43:40, brettw wrote:
> Actually, I think this can be compiled in to url_unittests in the parent
> directory. Adding another target here will just be a big headache (have to
> configure the bots to run it) and there's no reason why a unit test file
> couldn't just depend on IPC.
> 
> What I would do is keep this target as-is but change to a source_set, then add
> this source_set to the deps of //url:url_unittests

Done.

https://codereview.chromium.org/1722773002/diff/1/url/ipc/BUILD.gn#newcode22
url/ipc/BUILD.gn:22: "//url:url",
On 2016/02/22 22:07:15, brettw wrote:
> This can just be "//url",

N/A with removal.

[Fady Samuel, 2016-02-23 16:15:23]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 16:16:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/20001

[commit-bot: I haz the power, 2016-02-23 16:20:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:20:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-02-23 16:28:08]

Description was changed from

==========
Move GURL ParamTraits to url/ipc

We are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mark Dittmer, 2016-02-23 16:44:22]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 16:44:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/40001

[Tom Sepez, 2016-02-23 16:55:29]

lgtm

https://codereview.chromium.org/1722773002/diff/40001/url/ipc/url_param_trait...
File url/ipc/url_param_traits.cc (right):

https://codereview.chromium.org/1722773002/diff/40001/url/ipc/url_param_trait...
url/ipc/url_param_traits.cc:1: // Copyright (c) 2016 The Chromium Authors. All
rights reserved.
ditto

https://codereview.chromium.org/1722773002/diff/40001/url/ipc/url_param_traits.h
File url/ipc/url_param_traits.h (right):

https://codereview.chromium.org/1722773002/diff/40001/url/ipc/url_param_trait...
url/ipc/url_param_traits.h:1: // Copyright (c) 2016 The Chromium Authors. All
rights reserved.
Nit: no (c)

https://codereview.chromium.org/1722773002/diff/40001/url/ipc/url_param_trait...
File url/ipc/url_param_traits_unittest.cc (right):

https://codereview.chromium.org/1722773002/diff/40001/url/ipc/url_param_trait...
url/ipc/url_param_traits_unittest.cc:1: // Copyright (c) 2016 The Chromium
Authors. All rights reserved.
ditto

[commit-bot: I haz the power, 2016-02-23 17:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 17:15:34]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Mark Dittmer, 2016-02-23 18:49:05]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-02-23 18:49:05]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1722773002/#ps60001
(title: "Make url_unittests depend on url_ipc publicly")

[brettw, 2016-02-23 18:52:54]

https://codereview.chromium.org/1722773002/diff/60001/url/ipc/url_param_traits.h
File url/ipc/url_param_traits.h (right):

https://codereview.chromium.org/1722773002/diff/60001/url/ipc/url_param_trait...
url/ipc/url_param_traits.h:10: #include "url/url_export.h"
You still need to remove this and the URL_EXPORT reference below.

[commit-bot: I haz the power, 2016-02-23 18:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/60001

[commit-bot: I haz the power, 2016-02-23 19:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 19:15:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mark Dittmer, 2016-02-23 19:29:20]

Eliminate extraneous URL_EXPORT

[Mark Dittmer, 2016-02-23 19:29:34]

https://codereview.chromium.org/1722773002/diff/60001/url/ipc/url_param_traits.h
File url/ipc/url_param_traits.h (right):

https://codereview.chromium.org/1722773002/diff/60001/url/ipc/url_param_trait...
url/ipc/url_param_traits.h:10: #include "url/url_export.h"
On 2016/02/23 18:52:54, brettw wrote:
> You still need to remove this and the URL_EXPORT reference below.

Done.

[Mark Dittmer, 2016-02-23 19:50:50]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 19:57:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/80001

[brettw, 2016-02-23 20:17:58]

lgtm

https://codereview.chromium.org/1722773002/diff/80001/url/url.gyp
File url/url.gyp (right):

https://codereview.chromium.org/1722773002/diff/80001/url/url.gyp#newcode71
url/url.gyp:71: 'sources': [ 'ipc/url_param_traits_unittest.cc' ],
This should mirror the structure of the GN build (no separate ipc test target).

[commit-bot: I haz the power, 2016-02-23 20:39:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 20:39:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mark Dittmer, 2016-02-23 20:59:56]

Fix gyp:gn mirror on unittests target

[Mark Dittmer, 2016-02-25 18:34:02]

https://codereview.chromium.org/1722773002/diff/80001/url/url.gyp
File url/url.gyp (right):

https://codereview.chromium.org/1722773002/diff/80001/url/url.gyp#newcode71
url/url.gyp:71: 'sources': [ 'ipc/url_param_traits_unittest.cc' ],
On 2016/02/23 20:17:58, brettw wrote:
> This should mirror the structure of the GN build (no separate ipc test
target).

Done.

[Mark Dittmer, 2016-02-25 19:13:15]

More missing deps on url_ipc

[Mark Dittmer, 2016-02-25 21:01:52]

Refactor url/ipc code to build as a separate component

[Mark Dittmer, 2016-02-26 02:28:30]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 02:29:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/160001

[commit-bot: I haz the power, 2016-02-26 02:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 02:38:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Mark Dittmer, 2016-02-26 14:42:28]

rebase

[Mark Dittmer, 2016-02-26 14:44:03]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 14:44:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/170001

[commit-bot: I haz the power, 2016-02-26 14:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 14:54:32]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Mark Dittmer, 2016-02-26 15:32:09]

Move url_ipc unittests out of url.gyp to avoid detection of false dep loop

[Mark Dittmer, 2016-02-26 15:37:09]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-26 15:37:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/190001

[commit-bot: I haz the power, 2016-02-26 16:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 16:05:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Mark Dittmer, 2016-03-01 15:04:05]

Attempt to fix deps on common_param_traits and :content_common, and on
url_param_traits and :url_ipc

[Mark Dittmer, 2016-03-01 15:53:38]

Re-introduce some broken deps

[Mark Dittmer, 2016-03-01 19:54:26]

Add includes; fixes broken implicit deps when some includes were removed

[Mark Dittmer, 2016-03-01 19:55:24]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 19:55:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/250001

[Mark Dittmer, 2016-03-01 19:56:30]

markdittmer@chromium.org changed reviewers:
+ thakis@chromium.org

[Mark Dittmer, 2016-03-01 19:58:24]

On 2016/03/01 19:54:26, Mark Dittmer wrote:
> Add includes; fixes broken implicit deps when some includes were removed

Managed to make the build happy on my machine. Thanks, thakis@, for helping me
approach deps issues systematically.

thakis@ PTAL. tsepez@ I have changes to _messages files, but they're all
includes. Not sure whether you want to take another look.

[commit-bot: I haz the power, 2016-03-01 20:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 20:17:51]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mark Dittmer, 2016-03-01 20:29:32]

The CQ bit was unchecked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-01 20:30:11]

Add missing include to chrome_content_browser_client.cc

[Mark Dittmer, 2016-03-01 20:30:30]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 20:30:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/270001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/270001

[Mark Dittmer, 2016-03-01 22:00:52]

The CQ bit was unchecked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-01 22:01:56]

Add url_ipc deps for android webview

[Mark Dittmer, 2016-03-01 22:02:24]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 22:03:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/290001

[Fady Samuel, 2016-03-01 22:44:17]

Just some nits...

https://codereview.chromium.org/1722773002/diff/290001/components/network_hin...
File components/network_hints.gypi (right):

https://codereview.chromium.org/1722773002/diff/290001/components/network_hin...
components/network_hints.gypi:11: 'defines': [ 'URL_PARAM_TRAITS_FIX' ],
nit: Is this necessary?

https://codereview.chromium.org/1722773002/diff/290001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/1722773002/diff/290001/extensions/extensions....
extensions/extensions.gyp:204: 'defines': [ 'URL_PARAM_TRAITS_FIX' ],
Is this necessary?

https://codereview.chromium.org/1722773002/diff/290001/url/ipc/url_ipc.gyp
File url/ipc/url_ipc.gyp (right):

https://codereview.chromium.org/1722773002/diff/290001/url/ipc/url_ipc.gyp#ne...
url/ipc/url_ipc.gyp:21: 'URL_PARAM_TRAITS_FIX',
Is this necessary?

[Nico, 2016-03-01 23:35:41]

lgtm with comments

https://codereview.chromium.org/1722773002/diff/290001/chrome/chrome_common.gypi
File chrome/chrome_common.gypi (right):

https://codereview.chromium.org/1722773002/diff/290001/chrome/chrome_common.g...
chrome/chrome_common.gypi:503: ],
TABS

https://codereview.chromium.org/1722773002/diff/290001/url/ipc/url_param_trai...
File url/ipc/url_param_traits.h (right):

https://codereview.chromium.org/1722773002/diff/290001/url/ipc/url_param_trai...
url/ipc/url_param_traits.h:14: #endif
probably want to remove this :-)

https://codereview.chromium.org/1722773002/diff/290001/url/url_constants.h
File url/url_constants.h (right):

https://codereview.chromium.org/1722773002/diff/290001/url/url_constants.h#ne...
url/url_constants.h:35: URL_EXPORT extern const size_t kMaxURLChars;
consider making this non-extern non-exported. Just

   const size_t kMaxURLChars = ...;

Then the compiler can inline the constant everywhere. (For strings, we don't do
this so we don't end up with a bunch of copies of strings, but for ints that's
not really an issue.)

[commit-bot: I haz the power, 2016-03-02 01:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 01:11:54]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-03-02 12:40:36]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-02 12:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
piman@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1722773002/#ps290001
(title: "Add url_ipc deps for android webview")

[commit-bot: I haz the power, 2016-03-02 12:40:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/290001

[commit-bot: I haz the power, 2016-03-02 12:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 12:47:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark Dittmer, 2016-03-02 20:31:02]

rebase

[Mark Dittmer, 2016-03-02 20:31:21]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-02 20:31:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
brettw@chromium.org, thakis@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1722773002/#ps310001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-02 20:32:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/310001

[commit-bot: I haz the power, 2016-03-02 20:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 20:47:30]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-02 20:55:39]

Remove include reintroduced during rebase

[Mark Dittmer, 2016-03-02 20:56:41]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-02 20:56:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
brettw@chromium.org, thakis@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1722773002/#ps330001
(title: "Remove include reintroduced during rebase")

[commit-bot: I haz the power, 2016-03-02 20:57:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/330001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/330001

[commit-bot: I haz the power, 2016-03-02 22:42:01]

Description was changed from

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-02 22:42:04]

Committed patchset #18 (id:330001)

[commit-bot: I haz the power, 2016-03-02 22:44:06]

Description was changed from

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
==========

[commit-bot: I haz the power, 2016-03-02 22:44:09]

Patchset 18 (id:??) landed as
https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}

[Dmitry Titov, 2016-03-02 23:13:55]

A revert of this CL (patchset #18 id:330001) has been created in
https://codereview.chromium.org/1755363003/ by dimich@chromium.org.

The reason for reverting is: Broke compile on iOS_Simulator_GN_(dbg):
https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29....

[Mark Dittmer, 2016-03-03 13:07:53]

Description was changed from

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
==========

to

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
==========

[Mark Dittmer, 2016-03-03 17:39:13]

Drop url_unittests dep on url_ipc (not needed, and breaks iOS builds)

[Mark Dittmer, 2016-03-03 17:57:59]

Add url_ipc_unittests to high-level gyp build target

[Mark Dittmer, 2016-03-03 18:05:44]

Add url_ipc_unittests to high-level gn build target

[Mark Dittmer, 2016-03-03 18:09:54]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 18:10:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/390001

[commit-bot: I haz the power, 2016-03-03 19:21:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 19:21:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Mark Dittmer, 2016-03-03 20:17:15]

Get rid of defines used for testing deps

[Mark Dittmer, 2016-03-03 20:17:56]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 20:18:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/410001

[commit-bot: I haz the power, 2016-03-03 22:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 22:07:04]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-03-03 22:31:44]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-03 22:31:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
brettw@chromium.org, thakis@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1722773002/#ps410001
(title: "Get rid of defines used for testing deps")

[commit-bot: I haz the power, 2016-03-03 22:32:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722773002/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722773002/410001

[commit-bot: I haz the power, 2016-03-03 22:40:12]

Description was changed from

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
==========

to

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
==========

[commit-bot: I haz the power, 2016-03-03 22:40:15]

Committed patchset #22 (id:410001)

[commit-bot: I haz the power, 2016-03-03 22:42:32]

Description was changed from

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}
==========

to

==========
Move GURL ParamTraits to url/ipc

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is GURL. As per discussion here:
https://codereview.chromium.org/1703163002/, the plan of record is to move
GURL ParamTraits out of content/ and into url/.

BUG=586368
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa
Cr-Commit-Position: refs/heads/master@{#378859}

Committed: https://crrev.com/67b71ea2e11563a4c0363e1dce4e266cebcd063a
Cr-Commit-Position: refs/heads/master@{#379122}
==========

[commit-bot: I haz the power, 2016-03-03 22:42:35]

Patchset 22 (id:??) landed as
https://crrev.com/67b71ea2e11563a4c0363e1dce4e266cebcd063a
Cr-Commit-Position: refs/heads/master@{#379122}