mojo/shell/application_manager.cc - Issue 1722743002: Adds ability for chrome to behave as mojo_runner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/application_manager.cc

Issue 1722743002: Adds ability for chrome to behave as mojo_runner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chrome_mash, package_mash_services and NativeRunnerDelegate Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/application_manager.cc

diff --git a/mojo/shell/application_manager.cc b/mojo/shell/application_manager.cc

index 1a4cfa0a5913a0cff4c6f0c3cb1123c02b79f4c9..e1c78e812d8bbb942b21b2aa00d842e01f6c7dc1 100644

--- a/mojo/shell/application_manager.cc

+++ b/mojo/shell/application_manager.cc

@@ -334,7 +334,7 @@ void ApplicationManager::OnGotResolvedURL(

bool start_sandboxed = false;

base::FilePath path = util::UrlToFilePath(file_url.To<GURL>());

scoped_ptr<NativeRunner> runner = native_runner_factory_->Create(path);

- runner->Start(path, start_sandboxed, std::move(request),

+ runner->Start(path, target, start_sandboxed, std::move(request),

base::Bind(&ApplicationManager::ApplicationPIDAvailable,

weak_ptr_factory_.GetWeakPtr(), instance->id()),

base::Bind(&ApplicationManager::CleanupRunner,