Adds ability for chrome to behave as mojo_runner

Adds ability for chrome to behave as mojo_runner

This adds the arg use_mash that is only true on chromeos. Once
compiled with use_mash if you supply --mash to chrome it'll start the
shell inside chrome.
I haven't wired chrome up to start in this environment. Will do that
next.

BUG=581539
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/d6439eceec0ac412e5ce440847609a4d807e0f90
Cr-Commit-Position: refs/heads/master@{#377113}

[Ben Goodger (Google), 2016-02-22 20:20:01]

https://codereview.chromium.org/1722743002/diff/40001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/1722743002/diff/40001/chrome/BUILD.gn#newcode211
chrome/BUILD.gn:211: if (use_mash) {
you should give this variable a name that implies it's only related to the
packaging of mash components in chrome. as it stands, this variable will be
misused by people in a way that makes it impossible to test without using this
package.

I suggest "package_mash_services"

https://codereview.chromium.org/1722743002/diff/40001/chrome/app/mash/mash_ru...
File chrome/app/mash/mash_runner.cc (right):

https://codereview.chromium.org/1722743002/diff/40001/chrome/app/mash/mash_ru...
chrome/app/mash/mash_runner.cc:68: const GURL url = GURL(std::string(mojo_url));
what's the purpose of converting to a URL here? you're just doing string
comparisons.

[sky, 2016-02-23 00:01:34]

https://codereview.chromium.org/1722743002/diff/40001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/1722743002/diff/40001/chrome/BUILD.gn#newcode211
chrome/BUILD.gn:211: if (use_mash) {
On 2016/02/22 20:20:00, Ben Goodger (Google) wrote:
> you should give this variable a name that implies it's only related to the
> packaging of mash components in chrome. as it stands, this variable will be
> misused by people in a way that makes it impossible to test without using this
> package.
> 
> I suggest "package_mash_services"

I went with the wordy enable_package_mash_services.

https://codereview.chromium.org/1722743002/diff/40001/chrome/app/mash/mash_ru...
File chrome/app/mash/mash_runner.cc (right):

https://codereview.chromium.org/1722743002/diff/40001/chrome/app/mash/mash_ru...
chrome/app/mash/mash_runner.cc:68: const GURL url = GURL(std::string(mojo_url));
On 2016/02/22 20:20:00, Ben Goodger (Google) wrote:
> what's the purpose of converting to a URL here? you're just doing string
> comparisons.

As mentioned in person so that cannonicalization works. If I don't do that, then
I may have to have mojo://ash_sysui/. I don't want to worry about that;)

[Ben Goodger (Google), 2016-02-23 00:40:27]

lgtm

https://codereview.chromium.org/1722743002/diff/60001/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

https://codereview.chromium.org/1722743002/diff/60001/chrome/app/chrome_main....
chrome/app/chrome_main.cc:81: MashMain();
return MashMain()

[sky, 2016-02-23 21:30:51]

I think I finally sorted out the build. Here's a list of changes since you
looked:

. components/mus/gles2 was linking with
//mojo/platform_handle:for_shared_library . This resulted in duplicate symbols
when linking mus into chrome. Changed to //mojo/platform_handle (and a couple of
changes to mus itself to support this).
. Chrome already has a features header, so put the mash stuff there rather than
inventing another one.
. Got gyp to work (ugh!).

Take another look?

[Ben Goodger (Google), 2016-02-23 22:22:59]

lgtm

https://codereview.chromium.org/1722743002/diff/180001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/1722743002/diff/180001/chrome/common/BUILD.gn...
chrome/common/BUILD.gn:44: "ANDROID_JAVA_UI=$android_java_ui",
que?

[sky, 2016-02-23 22:27:13]

https://codereview.chromium.org/1722743002/diff/180001/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/1722743002/diff/180001/chrome/common/BUILD.gn...
chrome/common/BUILD.gn:44: "ANDROID_JAVA_UI=$android_java_ui",
On 2016/02/23 22:22:59, Ben Goodger (Google) wrote:
> que?

I sorted these to see if you were paying attention:)

[sky, 2016-02-23 22:27:30]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-02-23 22:36:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722743002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722743002/180001

[commit-bot: I haz the power, 2016-02-23 23:18:33]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-02-23 23:21:18]

Description was changed from

==========
Adds ability for chrome to behave as mojo_runner

This adds the arg use_mash that is only true on chromeos. Once
compiled with use_mash if you supply --mash to chrome it'll start the
shell inside chrome.
I haven't wired chrome up to start in this environment. Will do that
next.

BUG=581539
TEST=none
R=ben@chromium.org
==========

to

==========
Adds ability for chrome to behave as mojo_runner

This adds the arg use_mash that is only true on chromeos. Once
compiled with use_mash if you supply --mash to chrome it'll start the
shell inside chrome.
I haven't wired chrome up to start in this environment. Will do that
next.

BUG=581539
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/d6439eceec0ac412e5ce440847609a4d807e0f90
Cr-Commit-Position: refs/heads/master@{#377113}
==========

[commit-bot: I haz the power, 2016-02-23 23:21:19]

Patchset 10 (id:??) landed as
https://crrev.com/d6439eceec0ac412e5ce440847609a4d807e0f90
Cr-Commit-Position: refs/heads/master@{#377113}