Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1722673003: PlzNavigate: fix 2 SitePerProcessBrowserTests that were using the pending RFH (Closed)

Created:
4 years, 10 months ago by clamy
Modified:
4 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@navigation-policy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: fix 2 SitePerProcessBrowserTests that were using the pending RFH This Cl fixes 2 SitePerProcessBrowserTests that were using the pending RenderFrameHost. When BrowserSideNavigation is enabled, they now use the speculative RenderFrameHost. BUG=475027 Committed: https://crrev.com/5cba1481a15895b97141115c03a5ec3a6dd2df8e Cr-Commit-Position: refs/heads/master@{#377855}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
clamy
@nasko: PTAL
4 years, 10 months ago (2016-02-22 17:11:41 UTC) #3
nasko
LGTM
4 years, 10 months ago (2016-02-25 20:08:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722673003/20001
4 years, 10 months ago (2016-02-26 08:53:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 08:58:21 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 08:59:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5cba1481a15895b97141115c03a5ec3a6dd2df8e
Cr-Commit-Position: refs/heads/master@{#377855}

Powered by Google App Engine
This is Rietveld 408576698