Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1722643003: Reland of [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/mock_screen_orientation_client.cc ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_test_proxy.cc
diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc
index 9a6d1f8c1972758929b2e874d3f2d4a12d53b32c..0941d7a7a195bdbc9166e6b099ac91b4f4126f82 100644
--- a/components/test_runner/web_test_proxy.cc
+++ b/components/test_runner/web_test_proxy.cc
@@ -592,7 +592,7 @@
void WebTestProxyBase::GetScreenOrientationForTesting(
blink::WebScreenInfo& screen_info) {
- if (!screen_orientation_client_)
+ if (!screen_orientation_client_ || !screen_orientation_client_->is_active())
return;
// Override screen orientation information with mock data.
screen_info.orientationType =
« no previous file with comments | « components/test_runner/mock_screen_orientation_client.cc ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698