Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722603003: Roll PDFium 1e1d3b0..e4ac336 (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium 1e1d3b0..e4ac336 https://pdfium.googlesource.com/pdfium.git/+log/1e1d3b0..e4ac336 BUG=588200 Committed: https://crrev.com/4d6ba6e034703125e3b1218d499611ef3919feb6 Cr-Commit-Position: refs/heads/master@{#376909}

Patch Set 1 #

Patch Set 2 : init page event #

Patch Set 3 : roll some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Tom Sepez
stampy stamp LGTM
4 years, 10 months ago (2016-02-22 22:32:52 UTC) #3
Lei Zhang
On 2016/02/22 22:32:52, Tom Sepez wrote: > stampy stamp LGTM Well, let's see how many ...
4 years, 10 months ago (2016-02-22 22:40:09 UTC) #4
Lei Zhang
On 2016/02/22 22:40:09, Lei Zhang wrote: > On 2016/02/22 22:32:52, Tom Sepez wrote: > > ...
4 years, 10 months ago (2016-02-23 01:18:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722603003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722603003/40001
4 years, 10 months ago (2016-02-23 01:20:13 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-23 02:58:30 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 03:00:23 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4d6ba6e034703125e3b1218d499611ef3919feb6
Cr-Commit-Position: refs/heads/master@{#376909}

Powered by Google App Engine
This is Rietveld 408576698