Add metrics for interactions with the Apps Launcher promo dialog.

chrome/browser/ui/webui/ntp/app_launcher_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_
 
 #include <set>
 #include <string>
 
+#include "apps/metrics_names.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/ui/extensions/extension_enable_flow_delegate.h"
 #include "chrome/common/cancelable_task_tracker.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
@@ skipping 40 matching lines @@
   void FillAppDictionary(base::DictionaryValue* value);
 
   // Create a dictionary value for the given extension. May return NULL, e.g. if
   // the given extension is not an app. If non-NULL, the caller assumes
   // ownership of the pointer.
   base::DictionaryValue* GetAppInfo(const extensions::Extension* extension);
 
   // Populate the given dictionary with the web store promo content.
   void FillPromoDictionary(base::DictionaryValue* value);
 
-  // Callback for the "getApps" message.
-  void HandleGetApps(const base::ListValue* args);
-
-  // Callback for the "launchApp" message.
-  void HandleLaunchApp(const base::ListValue* args);
-
-  // Callback for the "setLaunchType" message.
-  void HandleSetLaunchType(const base::ListValue* args);
-
-  // Callback for the "uninstallApp" message.
-  void HandleUninstallApp(const base::ListValue* args);
-
-  // Callback for the "createAppShortcut" message.
-  void HandleCreateAppShortcut(const base::ListValue* args);
-
-  // Callback for the "reorderApps" message.
-  void HandleReorderApps(const base::ListValue* args);
-
-  // Callback for the "setPageIndex" message.
-  void HandleSetPageIndex(const base::ListValue* args);
-
-  // Callback for the "saveAppPageName" message.
-  void HandleSaveAppPageName(const base::ListValue* args);
-
-  // Callback for the "generateAppForLink" message.
-  void HandleGenerateAppForLink(const base::ListValue* args);
-
   // Callback for the "recordAppLaunchByURL" message. Takes an escaped URL and a
   // launch source (integer), and if the URL represents an app, records the
   // action for UMA.
   void HandleRecordAppLaunchByUrl(const base::ListValue* args);
 
-  // Callback for "stopShowingAppLauncherPromo" message.
+  // Other registered message callbacks.
   void StopShowingAppLauncherPromo(const base::ListValue* args);
-
-  // Callback for "closeNotification" message.
+  void OnLearnMore(const base::ListValue* args);
   void HandleNotificationClose(const base::ListValue* args);
-
-  // Callback for "setNotificationsDisabled" message.
   void HandleSetNotificationsDisabled(const base::ListValue* args);
+  void HandleGetApps(const base::ListValue* args);
+  void HandleLaunchApp(const base::ListValue* args);
+  void HandleSetLaunchType(const base::ListValue* args);
+  void HandleUninstallApp(const base::ListValue* args);
+  void HandleCreateAppShortcut(const base::ListValue* args);
+  void HandleReorderApps(const base::ListValue* args);
+  void HandleSetPageIndex(const base::ListValue* args);
+  void HandleSaveAppPageName(const base::ListValue* args);
+  void HandleGenerateAppForLink(const base::ListValue* args);

[Dan Beam, 2013/06/27 00:59:31]

nit: in theory these should mention which args will be passed to them (which is
why they're traditionally spread apart more like they were before)

[MAD, 2013/06/27 21:43:35]

Done.

 
   // Register app launcher preferences.
   static void RegisterUserPrefs(user_prefs::PrefRegistrySyncable* registry);
 
   // Records the given type of app launch for UMA.
   static void RecordAppLaunchType(extension_misc::AppLaunchBucket bucket,
                                   extensions::Manifest::Type app_type);
 
   // Records an app launch from the search view of the app list.
   static void RecordAppListSearchLaunch(const extensions::Extension* extension);
 
   // Records an app launch from the main view of the app list.
   static void RecordAppListMainLaunch(const extensions::Extension* extension);
 
+  static void RecordAppLauncherPromoHistogram(
+      apps::AppLauncherPromoHistogramValues histogram);

[Ilya Sherman, 2013/06/26 22:19:49]

nit: Docs?

[Ilya Sherman, 2013/06/26 22:19:49]

nit: "histogram" is a misleading variable name here; what you're recording is a
metric or a sample or a value, not a whole histogram.

[MAD, 2013/06/27 21:43:35]

Done.

[MAD, 2013/06/27 21:43:35]

Done.

+
  private:
   struct AppInstallInfo {
     AppInstallInfo();
     ~AppInstallInfo();
 
     bool is_bookmark_app;
     string16 title;
     GURL app_url;
     syncer::StringOrdinal page_ordinal;
   };
@@ skipping 79 matching lines @@
   // when the app is added to the page (via getAppsCallback or appAdded).
   std::string highlight_app_id_;
 
   // Used for favicon loading tasks.
   CancelableTaskTracker cancelable_task_tracker_;
 
   DISALLOW_COPY_AND_ASSIGN(AppLauncherHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_NTP_APP_LAUNCHER_HANDLER_H_