Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1722593002: [fullcodegen] Lift restriction on --debug-code flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/full-codegen.cc
diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc
index 52c413b83296894d12121bfe157bf130317dae4c..bd0ca46f5eb3c27eb316bbc4c29948c839cc8569 100644
--- a/src/full-codegen/full-codegen.cc
+++ b/src/full-codegen/full-codegen.cc
@@ -165,14 +165,7 @@ bool FullCodeGenerator::MustCreateArrayLiteralWithRuntime(
void FullCodeGenerator::Initialize() {
InitializeAstVisitor(info_->isolate());
- // The generation of debug code must match between the snapshot code and the
- // code that is generated later. This is assumed by the debugger when it is
- // calculating PC offsets after generating a debug version of code. Therefore
- // we disable the production of debug code in the full compiler if we are
- // either generating a snapshot or we booted from a snapshot.
- generate_debug_code_ = FLAG_debug_code && !masm_->serializer_enabled() &&
- !info_->isolate()->snapshot_available();
- masm_->set_emit_debug_code(generate_debug_code_);
+ masm_->set_emit_debug_code(FLAG_debug_code);
masm_->set_predictable_code_size(true);
}
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698