[fullcodegen] Lift restriction on --debug-code flag.

[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from full-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org

Committed: https://crrev.com/0427abf364e88bfda3c8e7f46c66f52637513620
Cr-Commit-Position: refs/heads/master@{#34189}

[Michael Starzinger, 2016-02-22 11:45:52]

Description was changed from

==========
[fullcodegen] Lift restriction on --debug-code flag.

R=
==========

to

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from fill-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org
==========

[Michael Starzinger, 2016-02-22 11:45:52]

mstarzinger@chromium.org changed reviewers:
+ machenbach@chromium.org, yangguo@chromium.org

[Michael Starzinger, 2016-02-22 11:48:56]

Yang: PTAL.
Michael A.: This is the change we discussed. I will look through the duration
measurements to see if anything spikes. Maybe you could have a brief look at it
as well, you might have a better intuition of where those spikes could hide.

[Michael Starzinger, 2016-02-22 11:49:20]

Description was changed from

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from fill-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org
==========

to

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from full-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org
==========

[Yang, 2016-02-22 12:08:55]

LGTM. Thanks for this clean up!

[Michael Achenbach, 2016-02-22 12:37:06]

lgtm! durations seem to hardly change at all...

[Michael Starzinger, 2016-02-22 12:38:43]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-02-22 12:38:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1722593002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1722593002/1

[commit-bot: I haz the power, 2016-02-22 12:40:41]

Description was changed from

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from full-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org
==========

to

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from full-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-02-22 12:40:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-22 12:41:34]

Description was changed from

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from full-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org
==========

to

==========
[fullcodegen] Lift restriction on --debug-code flag.

This removes a restriction from full-codegen that limited the usability
of the --debug-code flag to only no-snap configurations. The reasoning
for the restriction would still hold, if we ever put full-codegen code
into the snapshot, which we don't. Also there already are several places
in full-codegen that queried the FLAG_debug_code directly, a more
reliable mechanism will be needed if we snapshot full code.

R=yangguo@chromium.org

Committed: https://crrev.com/0427abf364e88bfda3c8e7f46c66f52637513620
Cr-Commit-Position: refs/heads/master@{#34189}
==========

[commit-bot: I haz the power, 2016-02-22 12:41:34]

Patchset 1 (id:??) landed as
https://crrev.com/0427abf364e88bfda3c8e7f46c66f52637513620
Cr-Commit-Position: refs/heads/master@{#34189}