Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722543003: Mojo bindings environment: remove usage in mojo/edk/js (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo bindings environment: remove usage in mojo/edk/js BUG=585942 Committed: https://crrev.com/418e6f8be0b625b4141380169ed07f5724032ac3 Cr-Commit-Position: refs/heads/master@{#377178}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : GYP change: move mojo_message_pump_lib to mojo_public.gyp #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -88 lines) Patch
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/message_port.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_utility.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/js/drain_data.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/edk/js/drain_data.cc View 1 3 chunks +5 lines, -14 lines 0 comments Download
M mojo/edk/js/test/run_js_tests.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/js/waiting_callback.h View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/edk/js/waiting_callback.cc View 1 2 4 chunks +16 lines, -26 lines 0 comments Download
M mojo/message_pump/handle_watcher.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 chunks +3 lines, -28 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_edk_tests.gyp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gyp View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
yzshen1
Hi, John. Would you please take a look? Thanks!
4 years, 10 months ago (2016-02-23 00:53:38 UTC) #2
jam
https://codereview.chromium.org/1722543003/diff/20001/mojo/edk/js/waiting_callback.cc File mojo/edk/js/waiting_callback.cc (right): https://codereview.chromium.org/1722543003/diff/20001/mojo/edk/js/waiting_callback.cc#newcode35 mojo/edk/js/waiting_callback.cc:35: waiting_callback->started_handle_watcher_ = true; i'm curious why keep this extra ...
4 years, 10 months ago (2016-02-23 16:54:13 UTC) #3
yzshen1
Thanks John. Would you please take another look? https://codereview.chromium.org/1722543003/diff/20001/mojo/edk/js/waiting_callback.cc File mojo/edk/js/waiting_callback.cc (right): https://codereview.chromium.org/1722543003/diff/20001/mojo/edk/js/waiting_callback.cc#newcode35 mojo/edk/js/waiting_callback.cc:35: waiting_callback->started_handle_watcher_ ...
4 years, 10 months ago (2016-02-23 21:22:07 UTC) #4
jam
lgtm
4 years, 10 months ago (2016-02-23 22:01:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722543003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722543003/80001
4 years, 10 months ago (2016-02-23 23:16:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/185709)
4 years, 10 months ago (2016-02-24 00:40:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722543003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722543003/80001
4 years, 10 months ago (2016-02-24 00:45:17 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-24 01:28:05 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 01:29:29 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/418e6f8be0b625b4141380169ed07f5724032ac3
Cr-Commit-Position: refs/heads/master@{#377178}

Powered by Google App Engine
This is Rietveld 408576698